Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwmon: Avoid initializing the same field twice

All hwmon drivers allocate their data structure with some form of
kzalloc, so setting data fields to zero explicitly is a waste of time.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>

-14
-1
drivers/hwmon/asc7621.c
··· 1115 1115 return -ENOMEM; 1116 1116 1117 1117 i2c_set_clientdata(client, data); 1118 - data->valid = 0; 1119 1118 mutex_init(&data->update_lock); 1120 1119 1121 1120 /* Initialize the asc7621 chip */
-2
drivers/hwmon/atxp1.c
··· 353 353 data->vrm = vid_which_vrm(); 354 354 355 355 i2c_set_clientdata(new_client, data); 356 - data->valid = 0; 357 - 358 356 mutex_init(&data->update_lock); 359 357 360 358 /* Register sysfs hooks */
-1
drivers/hwmon/lm77.c
··· 348 348 return -ENOMEM; 349 349 350 350 i2c_set_clientdata(client, data); 351 - data->valid = 0; 352 351 mutex_init(&data->update_lock); 353 352 354 353 /* Initialize the LM77 chip */
-1
drivers/hwmon/lm83.c
··· 349 349 return -ENOMEM; 350 350 351 351 i2c_set_clientdata(new_client, data); 352 - data->valid = 0; 353 352 mutex_init(&data->update_lock); 354 353 355 354 /*
-1
drivers/hwmon/lm87.c
··· 903 903 return -ENOMEM; 904 904 905 905 i2c_set_clientdata(client, data); 906 - data->valid = 0; 907 906 mutex_init(&data->update_lock); 908 907 909 908 /* Initialize the LM87 chip */
-1
drivers/hwmon/lm92.c
··· 380 380 return -ENOMEM; 381 381 382 382 i2c_set_clientdata(new_client, data); 383 - data->valid = 0; 384 383 mutex_init(&data->update_lock); 385 384 386 385 /* Initialize the chipset */
-1
drivers/hwmon/lm93.c
··· 2754 2754 i2c_set_clientdata(client, data); 2755 2755 2756 2756 /* housekeeping */ 2757 - data->valid = 0; 2758 2757 data->update = update; 2759 2758 mutex_init(&data->update_lock); 2760 2759
-1
drivers/hwmon/max1619.c
··· 273 273 return -ENOMEM; 274 274 275 275 i2c_set_clientdata(new_client, data); 276 - data->valid = 0; 277 276 mutex_init(&data->update_lock); 278 277 279 278 /* Initialize the MAX1619 chip */
-1
drivers/hwmon/w83792d.c
··· 1376 1376 return -ENOMEM; 1377 1377 1378 1378 i2c_set_clientdata(client, data); 1379 - data->valid = 0; 1380 1379 mutex_init(&data->update_lock); 1381 1380 1382 1381 err = w83792d_detect_subclients(client);
-4
drivers/hwmon/w83l785ts.c
··· 188 188 return -ENOMEM; 189 189 190 190 i2c_set_clientdata(client, data); 191 - data->valid = 0; 192 191 mutex_init(&data->update_lock); 193 - 194 - /* Default values in case the first read fails (unlikely). */ 195 - data->temp[1] = data->temp[0] = 0; 196 192 197 193 /* 198 194 * Initialize the W83L785TS chip