Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

HID: hid-logitech: remove redundant assignment to pointer value

The pointer value is being assigned a value and this is never read, and later
on it is being assigned a new value. This the first assignment is redundant
and can be removed and hence also the variables report and report_list. Cleans
up the clang warning: Value stored to 'value' during its initialization is
never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

authored by

Colin Ian King and committed by
Jiri Kosina
6cb6d98a 47af1cdb

+1 -3
+1 -3
drivers/hid/hid-lg4ff.c
··· 474 474 static void lg4ff_set_autocenter_default(struct input_dev *dev, u16 magnitude) 475 475 { 476 476 struct hid_device *hid = input_get_drvdata(dev); 477 - struct list_head *report_list = &hid->report_enum[HID_OUTPUT_REPORT].report_list; 478 - struct hid_report *report = list_entry(report_list->next, struct hid_report, list); 479 - s32 *value = report->field[0]->value; 477 + s32 *value; 480 478 u32 expand_a, expand_b; 481 479 struct lg4ff_device_entry *entry; 482 480 struct lg_drv_data *drv_data;