Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf tests dlfilter: Free desc and long_desc in check_filter_desc

In dlfilter-test.c, check_filter_desc() calls get_filter_desc() which
allocates 'desc' and 'long_desc'. However, these variables are never
deallocated.

This patch adds the missing free() calls.

Fixes: 9f9c9a8de2d5e96c ("perf tests: Add dlfilter test")
Signed-off-by: Riccardo Mancini <rickyman7@gmail.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20210820113132.724034-1-rickyman7@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

authored by

Riccardo Mancini and committed by
Arnaldo Carvalho de Melo
6ca822e5 ab3c0ddb

+9 -4
+9 -4
tools/perf/tests/dlfilter-test.c
··· 239 239 240 240 static int check_filter_desc(struct test_data *td) 241 241 { 242 - char *long_desc; 243 - char *desc; 242 + char *long_desc = NULL; 243 + char *desc = NULL; 244 + int ret; 244 245 245 246 if (get_filter_desc(td->dlfilters, "dlfilter-test-api-v0.so", &desc, &long_desc) && 246 247 long_desc && !strcmp(long_desc, "Filter used by the 'dlfilter C API' perf test") && 247 248 desc && !strcmp(desc, "dlfilter to test v0 C API")) 248 - return 0; 249 + ret = 0; 250 + else 251 + ret = -1; 249 252 250 - return -1; 253 + free(desc); 254 + free(long_desc); 255 + return ret; 251 256 } 252 257 253 258 static int get_ip_addr(struct test_data *td)