Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

irqchip/alpine-msi: Use irq_domain_add_hierarchy()

Use the irq_domain_add_hierarchy() helper to create the hierarchical
domain, which both serves as documentation and avoids poking at
irqdomain internals.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Hsin-Yi Wang <hsinyi@chromium.org>
Tested-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20230213104302.17307-15-johan+linaro@kernel.org

authored by

Johan Hovold and committed by
Marc Zyngier
6c889231 a14e7fdd

+3 -5
+3 -5
drivers/irqchip/irq-alpine-msi.c
··· 204 204 return -ENXIO; 205 205 } 206 206 207 - middle_domain = irq_domain_add_tree(NULL, 208 - &alpine_msix_middle_domain_ops, 209 - priv); 207 + middle_domain = irq_domain_add_hierarchy(gic_domain, 0, 0, NULL, 208 + &alpine_msix_middle_domain_ops, 209 + priv); 210 210 if (!middle_domain) { 211 211 pr_err("Failed to create the MSIX middle domain\n"); 212 212 return -ENOMEM; 213 213 } 214 - 215 - middle_domain->parent = gic_domain; 216 214 217 215 msi_domain = pci_msi_create_irq_domain(of_node_to_fwnode(node), 218 216 &alpine_msix_domain_info,