Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: adc: ti-lmp92064: add buffering support

Enable buffered reading of samples from the LMP92064 ADC.
The main benefit of this change is being able to read out current and
voltage measurements in a single transfer, allowing instantaneous power
measurements.

Reads into the buffer can be triggered by any software triggers, e.g.
the iio-trig-hrtimer:

$ mkdir /sys/kernel/config/iio/triggers/hrtimer/my-trigger
$ cat /sys/bus/iio/devices/iio\:device3/name
lmp92064
$ iio_readdev -t my-trigger -b 16 iio:device3 | hexdump
WARNING: High-speed mode not enabled
0000000 0000 0176 0101 0001 5507 abd5 7645 1768
0000010 0000 016d 0101 0001 ee1e ac6b 7645 1768
...

Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20230707063635.1496437-1-l.goehrs@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Leonard Göhrs and committed by
Jonathan Cameron
6c7bc1d2 1f2a4d50

+53
+53
drivers/iio/adc/ti-lmp92064.c
··· 16 16 #include <linux/spi/spi.h> 17 17 18 18 #include <linux/iio/iio.h> 19 + #include <linux/iio/buffer.h> 19 20 #include <linux/iio/driver.h> 21 + #include <linux/iio/triggered_buffer.h> 22 + #include <linux/iio/trigger_consumer.h> 20 23 21 24 #define TI_LMP92064_REG_CONFIG_A 0x0000 22 25 #define TI_LMP92064_REG_CONFIG_B 0x0001 ··· 94 91 .address = TI_LMP92064_CHAN_INC, 95 92 .info_mask_separate = 96 93 BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE), 94 + .scan_index = TI_LMP92064_CHAN_INC, 95 + .scan_type = { 96 + .sign = 'u', 97 + .realbits = 12, 98 + .storagebits = 16, 99 + }, 97 100 .datasheet_name = "INC", 98 101 }, 99 102 { ··· 107 98 .address = TI_LMP92064_CHAN_INV, 108 99 .info_mask_separate = 109 100 BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE), 101 + .scan_index = TI_LMP92064_CHAN_INV, 102 + .scan_type = { 103 + .sign = 'u', 104 + .realbits = 12, 105 + .storagebits = 16, 106 + }, 110 107 .datasheet_name = "INV", 111 108 }, 109 + IIO_CHAN_SOFT_TIMESTAMP(2), 110 + }; 111 + 112 + static const unsigned long lmp92064_scan_masks[] = { 113 + BIT(TI_LMP92064_CHAN_INC) | BIT(TI_LMP92064_CHAN_INV), 114 + 0 112 115 }; 113 116 114 117 static int lmp92064_read_meas(struct lmp92064_adc_priv *priv, u16 *res) ··· 190 169 default: 191 170 return -EINVAL; 192 171 } 172 + } 173 + 174 + static irqreturn_t lmp92064_trigger_handler(int irq, void *p) 175 + { 176 + struct iio_poll_func *pf = p; 177 + struct iio_dev *indio_dev = pf->indio_dev; 178 + struct lmp92064_adc_priv *priv = iio_priv(indio_dev); 179 + struct { 180 + u16 values[2]; 181 + int64_t timestamp __aligned(8); 182 + } data; 183 + int ret; 184 + 185 + memset(&data, 0, sizeof(data)); 186 + 187 + ret = lmp92064_read_meas(priv, data.values); 188 + if (ret) 189 + goto err; 190 + 191 + iio_push_to_buffers_with_timestamp(indio_dev, &data, 192 + iio_get_time_ns(indio_dev)); 193 + 194 + err: 195 + iio_trigger_notify_done(indio_dev->trig); 196 + 197 + return IRQ_HANDLED; 193 198 } 194 199 195 200 static int lmp92064_reset(struct lmp92064_adc_priv *priv, ··· 348 301 indio_dev->channels = lmp92064_adc_channels; 349 302 indio_dev->num_channels = ARRAY_SIZE(lmp92064_adc_channels); 350 303 indio_dev->info = &lmp92064_adc_info; 304 + indio_dev->available_scan_masks = lmp92064_scan_masks; 305 + 306 + ret = devm_iio_triggered_buffer_setup(dev, indio_dev, NULL, 307 + lmp92064_trigger_handler, NULL); 308 + if (ret) 309 + return dev_err_probe(dev, ret, "Failed to setup buffered read\n"); 351 310 352 311 return devm_iio_device_register(dev, indio_dev); 353 312 }