Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Merge branch 'net--dsa-mv88e6xxx-warn'

Andrew Lunn says:

====================
net: dsa: mv88e6xxx: Fixup C=1 W=1 warnings

Make the mv88e6xxx driver build cleanly with C=1 W=1.
====================

Signed-off-by: David S. Miller <davem@davemloft.net>

+11 -9
+1 -1
drivers/net/dsa/mv88e6xxx/chip.c
··· 1751 1751 } 1752 1752 1753 1753 if ((fs->flow_type & FLOW_EXT) && fs->m_ext.vlan_tci) { 1754 - if (fs->m_ext.vlan_tci != 0xffff) 1754 + if (fs->m_ext.vlan_tci != htons(0xffff)) 1755 1755 return -EOPNOTSUPP; 1756 1756 vid = be16_to_cpu(fs->h_ext.vlan_tci) & VLAN_VID_MASK; 1757 1757 }
+2 -2
drivers/net/dsa/mv88e6xxx/chip.h
··· 167 167 u16 masked; 168 168 struct irq_chip chip; 169 169 struct irq_domain *domain; 170 - unsigned int nirqs; 170 + int nirqs; 171 171 }; 172 172 173 173 /* state flags for mv88e6xxx_port_hwtstamp::state */ ··· 654 654 655 655 static inline u16 mv88e6xxx_port_mask(struct mv88e6xxx_chip *chip) 656 656 { 657 - return GENMASK(mv88e6xxx_num_ports(chip) - 1, 0); 657 + return GENMASK((s32)mv88e6xxx_num_ports(chip) - 1, 0); 658 658 } 659 659 660 660 static inline unsigned int mv88e6xxx_num_gpio(struct mv88e6xxx_chip *chip)
+2 -3
drivers/net/dsa/mv88e6xxx/global2.c
··· 876 876 877 877 static int mv88e6390_watchdog_action(struct mv88e6xxx_chip *chip, int irq) 878 878 { 879 - int err; 880 879 u16 reg; 881 880 882 881 mv88e6xxx_g2_write(chip, MV88E6390_G2_WDOG_CTL, 883 882 MV88E6390_G2_WDOG_CTL_PTR_EVENT); 884 - err = mv88e6xxx_g2_read(chip, MV88E6390_G2_WDOG_CTL, &reg); 883 + mv88e6xxx_g2_read(chip, MV88E6390_G2_WDOG_CTL, &reg); 885 884 886 885 dev_info(chip->dev, "Watchdog event: 0x%04x", 887 886 reg & MV88E6390_G2_WDOG_CTL_DATA_MASK); 888 887 889 888 mv88e6xxx_g2_write(chip, MV88E6390_G2_WDOG_CTL, 890 889 MV88E6390_G2_WDOG_CTL_PTR_HISTORY); 891 - err = mv88e6xxx_g2_read(chip, MV88E6390_G2_WDOG_CTL, &reg); 890 + mv88e6xxx_g2_read(chip, MV88E6390_G2_WDOG_CTL, &reg); 892 891 893 892 dev_info(chip->dev, "Watchdog history: 0x%04x", 894 893 reg & MV88E6390_G2_WDOG_CTL_DATA_MASK);
+6 -3
drivers/net/dsa/mv88e6xxx/global2_scratch.c
··· 44 44 /** 45 45 * mv88e6xxx_g2_scratch_gpio_get_bit - get a bit 46 46 * @chip: chip private data 47 - * @nr: bit index 47 + * @base_reg: base of scratch bits 48 + * @offset: index of bit within the register 48 49 * @set: is bit set? 49 50 */ 50 51 static int mv88e6xxx_g2_scratch_get_bit(struct mv88e6xxx_chip *chip, ··· 69 68 /** 70 69 * mv88e6xxx_g2_scratch_gpio_set_bit - set (or clear) a bit 71 70 * @chip: chip private data 72 - * @nr: bit index 73 - * @set: set if true, clear if false 71 + * @base_reg: base of scratch bits 72 + * @offset: index of bit within the register 73 + * @set: should this bit be set? 74 74 * 75 75 * Helper function for dealing with the direction and data registers. 76 76 */ ··· 167 165 * mv88e6352_g2_scratch_gpio_set_dir - set direction of gpio pin 168 166 * @chip: chip private data 169 167 * @pin: gpio index 168 + * @input: should the gpio be an input, or an output? 170 169 */ 171 170 static int mv88e6352_g2_scratch_gpio_set_dir(struct mv88e6xxx_chip *chip, 172 171 unsigned int pin, bool input)