Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/amd/display: Convert documentation to a kernel-doc

The dc_dmub_srv file has a lot of documentation associated with SubVP
that could be converted to a kernel-doc. This commit just changes the
comment style to a kernel-doc.

Tested-by: Mark Broadworth <mark.broadworth@amd.com>
Reviewed-by: Aurabindo Pillai <Aurabindo.Pillai@amd.com>
Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

authored by

Rodrigo Siqueira and committed by
Alex Deucher
6be153dc bd829d57

+48 -76
+48 -76
drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
··· 423 423 424 424 #ifdef CONFIG_DRM_AMD_DC_DCN 425 425 /** 426 - * *********************************************************************************************** 427 - * populate_subvp_cmd_drr_info: Helper to populate DRR pipe info for the DMCUB subvp command 426 + * populate_subvp_cmd_drr_info - Helper to populate DRR pipe info for the DMCUB subvp command 428 427 * 429 - * Populate the DMCUB SubVP command with DRR pipe info. All the information required for calculating 430 - * the SubVP + DRR microschedule is populated here. 428 + * @dc: [in] current dc state 429 + * @subvp_pipe: [in] pipe_ctx for the SubVP pipe 430 + * @vblank_pipe: [in] pipe_ctx for the DRR pipe 431 + * @pipe_data: [in] Pipe data which stores the VBLANK/DRR info 432 + * 433 + * Populate the DMCUB SubVP command with DRR pipe info. All the information 434 + * required for calculating the SubVP + DRR microschedule is populated here. 431 435 * 432 436 * High level algorithm: 433 437 * 1. Get timing for SubVP pipe, phantom pipe, and DRR pipe 434 438 * 2. Calculate the min and max vtotal which supports SubVP + DRR microschedule 435 439 * 3. Populate the drr_info with the min and max supported vtotal values 436 - * 437 - * @param [in] dc: current dc state 438 - * @param [in] subvp_pipe: pipe_ctx for the SubVP pipe 439 - * @param [in] vblank_pipe: pipe_ctx for the DRR pipe 440 - * @param [in] pipe_data: Pipe data which stores the VBLANK/DRR info 441 - * 442 - * @return: void 443 - * 444 - * *********************************************************************************************** 445 440 */ 446 441 static void populate_subvp_cmd_drr_info(struct dc *dc, 447 442 struct pipe_ctx *subvp_pipe, ··· 488 493 } 489 494 490 495 /** 491 - * *********************************************************************************************** 492 - * populate_subvp_cmd_vblank_pipe_info: Helper to populate VBLANK pipe info for the DMUB subvp command 496 + * populate_subvp_cmd_vblank_pipe_info - Helper to populate VBLANK pipe info for the DMUB subvp command 493 497 * 494 - * Populate the DMCUB SubVP command with VBLANK pipe info. All the information required to calculate 495 - * the microschedule for SubVP + VBLANK case is stored in the pipe_data (subvp_data and vblank_data). 496 - * Also check if the VBLANK pipe is a DRR display -- if it is make a call to populate drr_info. 498 + * @dc: [in] current dc state 499 + * @context: [in] new dc state 500 + * @cmd: [in] DMUB cmd to be populated with SubVP info 501 + * @vblank_pipe: [in] pipe_ctx for the VBLANK pipe 502 + * @cmd_pipe_index: [in] index for the pipe array in DMCUB SubVP cmd 497 503 * 498 - * @param [in] dc: current dc state 499 - * @param [in] context: new dc state 500 - * @param [in] cmd: DMUB cmd to be populated with SubVP info 501 - * @param [in] vblank_pipe: pipe_ctx for the VBLANK pipe 502 - * @param [in] cmd_pipe_index: index for the pipe array in DMCUB SubVP cmd 503 - * 504 - * @return: void 505 - * 506 - * *********************************************************************************************** 504 + * Populate the DMCUB SubVP command with VBLANK pipe info. All the information 505 + * required to calculate the microschedule for SubVP + VBLANK case is stored in 506 + * the pipe_data (subvp_data and vblank_data). Also check if the VBLANK pipe 507 + * is a DRR display -- if it is make a call to populate drr_info. 507 508 */ 508 509 static void populate_subvp_cmd_vblank_pipe_info(struct dc *dc, 509 510 struct dc_state *context, ··· 542 551 } 543 552 544 553 /** 545 - * *********************************************************************************************** 546 - * update_subvp_prefetch_end_to_mall_start: Helper for SubVP + SubVP case 554 + * update_subvp_prefetch_end_to_mall_start - Helper for SubVP + SubVP case 547 555 * 548 - * For SubVP + SubVP, we use a single vertical interrupt to start the microschedule for both 549 - * SubVP pipes. In order for this to work correctly, the MALL REGION of both SubVP pipes must 550 - * start at the same time. This function lengthens the prefetch end to mall start delay of the 551 - * SubVP pipe that has the shorter prefetch so that both MALL REGION's will start at the same time. 556 + * @dc: [in] current dc state 557 + * @context: [in] new dc state 558 + * @cmd: [in] DMUB cmd to be populated with SubVP info 559 + * @subvp_pipes: [in] Array of SubVP pipes (should always be length 2) 552 560 * 553 - * @param [in] dc: current dc state 554 - * @param [in] context: new dc state 555 - * @param [in] cmd: DMUB cmd to be populated with SubVP info 556 - * @param [in] subvp_pipes: Array of SubVP pipes (should always be length 2) 557 - * 558 - * @return: void 559 - * 560 - * *********************************************************************************************** 561 + * For SubVP + SubVP, we use a single vertical interrupt to start the 562 + * microschedule for both SubVP pipes. In order for this to work correctly, the 563 + * MALL REGION of both SubVP pipes must start at the same time. This function 564 + * lengthens the prefetch end to mall start delay of the SubVP pipe that has 565 + * the shorter prefetch so that both MALL REGION's will start at the same time. 561 566 */ 562 567 static void update_subvp_prefetch_end_to_mall_start(struct dc *dc, 563 568 struct dc_state *context, ··· 595 608 } 596 609 597 610 /** 598 - * *************************************************************************************** 599 - * setup_subvp_dmub_command: Helper to populate the SubVP pipe info for the DMUB subvp command 611 + * setup_subvp_dmub_command - Helper to populate the SubVP pipe info for the DMUB subvp command 600 612 * 601 - * Populate the DMCUB SubVP command with SubVP pipe info. All the information required to 602 - * calculate the microschedule for the SubVP pipe is stored in the pipe_data of the DMCUB 603 - * SubVP command. 613 + * @dc: [in] current dc state 614 + * @context: [in] new dc state 615 + * @cmd: [in] DMUB cmd to be populated with SubVP info 616 + * @subvp_pipe: [in] pipe_ctx for the SubVP pipe 617 + * @cmd_pipe_index: [in] index for the pipe array in DMCUB SubVP cmd 604 618 * 605 - * @param [in] dc: current dc state 606 - * @param [in] context: new dc state 607 - * @param [in] cmd: DMUB cmd to be populated with SubVP info 608 - * @param [in] subvp_pipe: pipe_ctx for the SubVP pipe 609 - * @param [in] cmd_pipe_index: index for the pipe array in DMCUB SubVP cmd 610 - * 611 - * @return: void 612 - * 613 - * *************************************************************************************** 619 + * Populate the DMCUB SubVP command with SubVP pipe info. All the information 620 + * required to calculate the microschedule for the SubVP pipe is stored in the 621 + * pipe_data of the DMCUB SubVP command. 614 622 */ 615 623 static void populate_subvp_cmd_pipe_info(struct dc *dc, 616 624 struct dc_state *context, ··· 685 703 } 686 704 687 705 /** 688 - * *************************************************************************************** 689 - * dc_dmub_setup_subvp_dmub_command: Populate the DMCUB SubVP command 706 + * dc_dmub_setup_subvp_dmub_command - Populate the DMCUB SubVP command 690 707 * 691 - * This function loops through each pipe and populates the DMUB 692 - * SubVP CMD info based on the pipe (e.g. SubVP, VBLANK). 708 + * @dc: [in] current dc state 709 + * @context: [in] new dc state 710 + * @cmd: [in] DMUB cmd to be populated with SubVP info 693 711 * 694 - * @param [in] dc: current dc state 695 - * @param [in] context: new dc state 696 - * @param [in] cmd: DMUB cmd to be populated with SubVP info 697 - * 698 - * @return: void 699 - * 700 - * *************************************************************************************** 712 + * This function loops through each pipe and populates the DMUB SubVP CMD info 713 + * based on the pipe (e.g. SubVP, VBLANK). 701 714 */ 702 715 void dc_dmub_setup_subvp_dmub_command(struct dc *dc, 703 716 struct dc_state *context, ··· 939 962 } 940 963 941 964 /** 942 - * *************************************************************************************** 943 - * dc_send_update_cursor_info_to_dmu: Populate the DMCUB Cursor update info command 965 + * dc_send_update_cursor_info_to_dmu - Populate the DMCUB Cursor update info command 944 966 * 945 - * This function would store the cursor related information and pass it into dmub 967 + * @pCtx: [in] pipe context 968 + * @pipe_idx: [in] pipe index 946 969 * 947 - * @param [in] pCtx: pipe context 948 - * @param [in] pipe_idx: pipe index 949 - * 950 - * @return: void 951 - * 952 - * *************************************************************************************** 970 + * This function would store the cursor related information and pass it into 971 + * dmub 953 972 */ 954 - 955 973 void dc_send_update_cursor_info_to_dmu( 956 974 struct pipe_ctx *pCtx, uint8_t pipe_idx) 957 975 {