Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

irq/work: Improve the flag definitions

IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it
says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise
OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY and change its name to
IRQ_WORK_CLAIMED.

While we're at it: use the BIT() macro for all flags.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1515125996-21564-1-git-send-email-frederic@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>

authored by

Bartosz Golaszewski and committed by
Ingo Molnar
6baf9e67 b2cd1df6

+8 -5
+7 -4
include/linux/irq_work.h
··· 13 13 * busy NULL, 2 -> {free, claimed} : callback in progress, can be claimed 14 14 */ 15 15 16 - #define IRQ_WORK_PENDING 1UL 17 - #define IRQ_WORK_BUSY 2UL 18 - #define IRQ_WORK_FLAGS 3UL 19 - #define IRQ_WORK_LAZY 4UL /* Doesn't want IPI, wait for tick */ 16 + #define IRQ_WORK_PENDING BIT(0) 17 + #define IRQ_WORK_BUSY BIT(1) 18 + 19 + /* Doesn't want IPI, wait for tick: */ 20 + #define IRQ_WORK_LAZY BIT(2) 21 + 22 + #define IRQ_WORK_CLAIMED (IRQ_WORK_PENDING | IRQ_WORK_BUSY) 20 23 21 24 struct irq_work { 22 25 unsigned long flags;
+1 -1
kernel/irq_work.c
··· 36 36 */ 37 37 flags = work->flags & ~IRQ_WORK_PENDING; 38 38 for (;;) { 39 - nflags = flags | IRQ_WORK_FLAGS; 39 + nflags = flags | IRQ_WORK_CLAIMED; 40 40 oflags = cmpxchg(&work->flags, flags, nflags); 41 41 if (oflags == flags) 42 42 break;