Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Input: sur40 - fix interface sanity checks

Make sure to use the current alternate setting when verifying the
interface descriptors to avoid binding to an invalid interface.

This in turn could cause the driver to misbehave or trigger a WARN() in
usb_submit_urb() that kernels with panic_on_warn set would choke on.

Fixes: bdb5c57f209c ("Input: add sur40 driver for Samsung SUR40 (aka MS Surface 2.0/Pixelsense)")
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Vladis Dronov <vdronov@redhat.com>
Link: https://lore.kernel.org/r/20191210113737.4016-8-johan@kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

authored by

Johan Hovold and committed by
Dmitry Torokhov
6b32391e cea79911

+1 -1
+1 -1
drivers/input/touchscreen/sur40.c
··· 661 661 int error; 662 662 663 663 /* Check if we really have the right interface. */ 664 - iface_desc = &interface->altsetting[0]; 664 + iface_desc = interface->cur_altsetting; 665 665 if (iface_desc->desc.bInterfaceClass != 0xFF) 666 666 return -ENODEV; 667 667