Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ALSA: pci/oxygen/xonar_wm87x6: remove always true condition

Fix W=1 warnings:

sound/pci/oxygen/xonar_wm87x6.c: In function ‘wm8776_write’:
sound/pci/oxygen/xonar_wm87x6.c:119:11: warning: comparison of
unsigned expression >= 0 is always true [-Wtype-limits]
119 | if (reg >= WM8776_HPLVOL && reg <= WM8776_DACMASTER)
| ^~
sound/pci/oxygen/xonar_wm87x6.c: In function ‘wm8766_write’:
sound/pci/oxygen/xonar_wm87x6.c:147:12: warning: comparison of
unsigned expression >= 0 is always true [-Wtype-limits]
147 | if ((reg >= WM8766_LDA1 && reg <= WM8766_RDA1) ||
| ^~

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200702193604.169059-17-pierre-louis.bossart@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>

authored by

Pierre-Louis Bossart and committed by
Takashi Iwai
6add6b02 ab3ee092

+4 -2
+4 -2
sound/pci/oxygen/xonar_wm87x6.c
··· 116 116 else 117 117 wm8776_write_i2c(chip, reg, value); 118 118 if (reg < ARRAY_SIZE(data->wm8776_regs)) { 119 - if (reg >= WM8776_HPLVOL && reg <= WM8776_DACMASTER) 119 + /* reg >= WM8776_HPLVOL is always true */ 120 + if (reg <= WM8776_DACMASTER) 120 121 value &= ~WM8776_UPDATE; 121 122 data->wm8776_regs[reg] = value; 122 123 } ··· 145 144 OXYGEN_SPI_CEN_LATCH_CLOCK_LO, 146 145 (reg << 9) | value); 147 146 if (reg < ARRAY_SIZE(data->wm8766_regs)) { 148 - if ((reg >= WM8766_LDA1 && reg <= WM8766_RDA1) || 147 + /* reg >= WM8766_LDA1 is always true */ 148 + if (reg <= WM8766_RDA1 || 149 149 (reg >= WM8766_LDA2 && reg <= WM8766_MASTDA)) 150 150 value &= ~WM8766_UPDATE; 151 151 data->wm8766_regs[reg] = value;