Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

objtool: Print top level commands on incorrect usage

Print top-level objtool commands, along with the error on incorrect
command line usage. Objtool command line parser exit's with code 129,
for incorrect usage. Convert the cmd_usage() exit code also, to maintain
consistency across objtool.

After the patch:

$ ./objtool -j

Unknown option: -j

usage: objtool COMMAND [ARGS]

Commands:
check Perform stack metadata validation on an object file
orc Generate in-place ORC unwind tables for an object file

$ echo $?
129

Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1507992474-16142-1-git-send-email-kamalesh@linux.vnet.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>

authored by

Kamalesh Babulal and committed by
Ingo Molnar
6a93bb7e 2704fbb6

+2 -4
+2 -4
tools/objtool/objtool.c
··· 70 70 71 71 printf("\n"); 72 72 73 - exit(1); 73 + exit(129); 74 74 } 75 75 76 76 static void handle_options(int *argc, const char ***argv) ··· 86 86 break; 87 87 } else { 88 88 fprintf(stderr, "Unknown option: %s\n", cmd); 89 - fprintf(stderr, "\n Usage: %s\n", 90 - objtool_usage_string); 91 - exit(1); 89 + cmd_usage(); 92 90 } 93 91 94 92 (*argv)++;