Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: use 'depends' instead of 'select' for SCSI_FC_ATTRS

There are other kconfig symbols which use SCSI_FC_ATTRS.
In order to maintain sanity and prevent kconfig warnings, change
all of these from using 'select' to using 'depends on' so that
proper symbol dependencies will be honored and circular depends
problems will be avoided.
This fixes kconfig warnings and build errors:

warning: (LIBFC && SCSI_IBMVFC && SCSI_QLA_FC && SCSI_LPFC && ZFCP && SCSI_BFA_FC && SCSI_CHELSIO_FCOE && FUSION_FC) selects SCSI_FC_ATTRS which has unmet direct dependencies (SCSI && NET)
drivers/scsi/scsi_transport_fc.c: In function 'fc_host_post_event':
drivers/scsi/scsi_transport_fc.c:543:7: error: 'scsi_nl_sock' undeclared (first use in this function)
drivers/scsi/scsi_transport_fc.c: In function 'fc_host_post_vendor_event':
drivers/scsi/scsi_transport_fc.c:611:7: error: 'scsi_nl_sock' undeclared (first use in this function)

Reported-by: Fengguang Wu <fengguang.wu@intel.com> [0-day test robot]
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Randy Dunlap and committed by
David S. Miller
6a38792c f650fb45

+8 -8
+1 -1
drivers/message/fusion/Kconfig
··· 29 29 config FUSION_FC 30 30 tristate "Fusion MPT ScsiHost drivers for FC" 31 31 depends on PCI && SCSI 32 - select SCSI_FC_ATTRS 32 + depends on SCSI_FC_ATTRS 33 33 ---help--- 34 34 SCSI HOST support for a Fiber Channel host adapters. 35 35
+5 -5
drivers/scsi/Kconfig
··· 585 585 586 586 config LIBFC 587 587 tristate "LibFC module" 588 - select SCSI_FC_ATTRS 588 + depends on SCSI_FC_ATTRS 589 589 select CRC32 590 590 ---help--- 591 591 Fibre Channel library module ··· 816 816 config SCSI_IBMVFC 817 817 tristate "IBM Virtual FC support" 818 818 depends on PPC_PSERIES && SCSI 819 - select SCSI_FC_ATTRS 819 + depends on SCSI_FC_ATTRS 820 820 help 821 821 This is the IBM POWER Virtual FC Client 822 822 ··· 1266 1266 config SCSI_LPFC 1267 1267 tristate "Emulex LightPulse Fibre Channel Support" 1268 1268 depends on PCI && SCSI 1269 - select SCSI_FC_ATTRS 1269 + depends on SCSI_FC_ATTRS 1270 1270 select CRC_T10DIF 1271 1271 help 1272 1272 This lpfc driver supports the Emulex LightPulse ··· 1676 1676 config ZFCP 1677 1677 tristate "FCP host bus adapter driver for IBM eServer zSeries" 1678 1678 depends on S390 && QDIO && SCSI 1679 - select SCSI_FC_ATTRS 1679 + depends on SCSI_FC_ATTRS 1680 1680 help 1681 1681 If you want to access SCSI devices attached to your IBM eServer 1682 1682 zSeries by means of Fibre Channel interfaces say Y. ··· 1704 1704 config SCSI_BFA_FC 1705 1705 tristate "Brocade BFA Fibre Channel Support" 1706 1706 depends on PCI && SCSI 1707 - select SCSI_FC_ATTRS 1707 + depends on SCSI_FC_ATTRS 1708 1708 help 1709 1709 This bfa driver supports all Brocade PCIe FC/FCOE host adapters. 1710 1710
+1 -1
drivers/scsi/csiostor/Kconfig
··· 1 1 config SCSI_CHELSIO_FCOE 2 2 tristate "Chelsio Communications FCoE support" 3 3 depends on PCI && SCSI 4 - select SCSI_FC_ATTRS 4 + depends on SCSI_FC_ATTRS 5 5 select FW_LOADER 6 6 help 7 7 This driver supports FCoE Offload functionality over
+1 -1
drivers/scsi/qla2xxx/Kconfig
··· 1 1 config SCSI_QLA_FC 2 2 tristate "QLogic QLA2XXX Fibre Channel Support" 3 3 depends on PCI && SCSI 4 - select SCSI_FC_ATTRS 4 + depends on SCSI_FC_ATTRS 5 5 select FW_LOADER 6 6 ---help--- 7 7 This qla2xxx driver supports all QLogic Fibre Channel