Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pinctrl: mvebu: Use devm_pinctrl_register() for pinctrl registration

Use devm_pinctrl_register() for pin control registration and remove
need of .remove callback.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Hongzhou Yang <hongzhou.yang@mediatek.com>
Cc: Fabian Frederick <fabf@skynet.be>
Cc: Andrew Andrianov <andrew@ncrmnt.org>
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

authored by

Laxman Dewangan and committed by
Linus Walleij
699097a9 e649f7ec

+2 -55
-6
drivers/pinctrl/mvebu/pinctrl-armada-370.c
··· 417 417 return mvebu_pinctrl_probe(pdev); 418 418 } 419 419 420 - static int armada_370_pinctrl_remove(struct platform_device *pdev) 421 - { 422 - return mvebu_pinctrl_remove(pdev); 423 - } 424 - 425 420 static struct platform_driver armada_370_pinctrl_driver = { 426 421 .driver = { 427 422 .name = "armada-370-pinctrl", 428 423 .of_match_table = armada_370_pinctrl_of_match, 429 424 }, 430 425 .probe = armada_370_pinctrl_probe, 431 - .remove = armada_370_pinctrl_remove, 432 426 }; 433 427 434 428 module_platform_driver(armada_370_pinctrl_driver);
-6
drivers/pinctrl/mvebu/pinctrl-armada-375.c
··· 435 435 return mvebu_pinctrl_probe(pdev); 436 436 } 437 437 438 - static int armada_375_pinctrl_remove(struct platform_device *pdev) 439 - { 440 - return mvebu_pinctrl_remove(pdev); 441 - } 442 - 443 438 static struct platform_driver armada_375_pinctrl_driver = { 444 439 .driver = { 445 440 .name = "armada-375-pinctrl", 446 441 .of_match_table = of_match_ptr(armada_375_pinctrl_of_match), 447 442 }, 448 443 .probe = armada_375_pinctrl_probe, 449 - .remove = armada_375_pinctrl_remove, 450 444 }; 451 445 452 446 module_platform_driver(armada_375_pinctrl_driver);
-6
drivers/pinctrl/mvebu/pinctrl-armada-38x.c
··· 446 446 return mvebu_pinctrl_probe(pdev); 447 447 } 448 448 449 - static int armada_38x_pinctrl_remove(struct platform_device *pdev) 450 - { 451 - return mvebu_pinctrl_remove(pdev); 452 - } 453 - 454 449 static struct platform_driver armada_38x_pinctrl_driver = { 455 450 .driver = { 456 451 .name = "armada-38x-pinctrl", 457 452 .of_match_table = of_match_ptr(armada_38x_pinctrl_of_match), 458 453 }, 459 454 .probe = armada_38x_pinctrl_probe, 460 - .remove = armada_38x_pinctrl_remove, 461 455 }; 462 456 463 457 module_platform_driver(armada_38x_pinctrl_driver);
-6
drivers/pinctrl/mvebu/pinctrl-armada-39x.c
··· 428 428 return mvebu_pinctrl_probe(pdev); 429 429 } 430 430 431 - static int armada_39x_pinctrl_remove(struct platform_device *pdev) 432 - { 433 - return mvebu_pinctrl_remove(pdev); 434 - } 435 - 436 431 static struct platform_driver armada_39x_pinctrl_driver = { 437 432 .driver = { 438 433 .name = "armada-39x-pinctrl", 439 434 .of_match_table = of_match_ptr(armada_39x_pinctrl_of_match), 440 435 }, 441 436 .probe = armada_39x_pinctrl_probe, 442 - .remove = armada_39x_pinctrl_remove, 443 437 }; 444 438 445 439 module_platform_driver(armada_39x_pinctrl_driver);
-6
drivers/pinctrl/mvebu/pinctrl-armada-xp.c
··· 502 502 return mvebu_pinctrl_probe(pdev); 503 503 } 504 504 505 - static int armada_xp_pinctrl_remove(struct platform_device *pdev) 506 - { 507 - return mvebu_pinctrl_remove(pdev); 508 - } 509 - 510 505 static struct platform_driver armada_xp_pinctrl_driver = { 511 506 .driver = { 512 507 .name = "armada-xp-pinctrl", 513 508 .of_match_table = armada_xp_pinctrl_of_match, 514 509 }, 515 510 .probe = armada_xp_pinctrl_probe, 516 - .remove = armada_xp_pinctrl_remove, 517 511 .suspend = armada_xp_pinctrl_suspend, 518 512 .resume = armada_xp_pinctrl_resume, 519 513 };
+1 -4
drivers/pinctrl/mvebu/pinctrl-dove.c
··· 840 840 841 841 static int dove_pinctrl_remove(struct platform_device *pdev) 842 842 { 843 - int ret; 844 - 845 - ret = mvebu_pinctrl_remove(pdev); 846 843 if (!IS_ERR(clk)) 847 844 clk_disable_unprepare(clk); 848 - return ret; 845 + return 0; 849 846 } 850 847 851 848 static struct platform_driver dove_pinctrl_driver = {
-6
drivers/pinctrl/mvebu/pinctrl-kirkwood.c
··· 481 481 return mvebu_pinctrl_probe(pdev); 482 482 } 483 483 484 - static int kirkwood_pinctrl_remove(struct platform_device *pdev) 485 - { 486 - return mvebu_pinctrl_remove(pdev); 487 - } 488 - 489 484 static struct platform_driver kirkwood_pinctrl_driver = { 490 485 .driver = { 491 486 .name = "kirkwood-pinctrl", 492 487 .of_match_table = kirkwood_pinctrl_of_match, 493 488 }, 494 489 .probe = kirkwood_pinctrl_probe, 495 - .remove = kirkwood_pinctrl_remove, 496 490 }; 497 491 498 492 module_platform_driver(kirkwood_pinctrl_driver);
+1 -8
drivers/pinctrl/mvebu/pinctrl-mvebu.c
··· 711 711 return ret; 712 712 } 713 713 714 - pctl->pctldev = pinctrl_register(&pctl->desc, &pdev->dev, pctl); 714 + pctl->pctldev = devm_pinctrl_register(&pdev->dev, &pctl->desc, pctl); 715 715 if (IS_ERR(pctl->pctldev)) { 716 716 dev_err(&pdev->dev, "unable to register pinctrl driver\n"); 717 717 return PTR_ERR(pctl->pctldev); ··· 723 723 for (n = 0; n < soc->ngpioranges; n++) 724 724 pinctrl_add_gpio_range(pctl->pctldev, &soc->gpioranges[n]); 725 725 726 - return 0; 727 - } 728 - 729 - int mvebu_pinctrl_remove(struct platform_device *pdev) 730 - { 731 - struct mvebu_pinctrl *pctl = platform_get_drvdata(pdev); 732 - pinctrl_unregister(pctl->pctldev); 733 726 return 0; 734 727 }
-1
drivers/pinctrl/mvebu/pinctrl-mvebu.h
··· 202 202 } 203 203 204 204 int mvebu_pinctrl_probe(struct platform_device *pdev); 205 - int mvebu_pinctrl_remove(struct platform_device *pdev); 206 205 207 206 #endif
-6
drivers/pinctrl/mvebu/pinctrl-orion.c
··· 239 239 return mvebu_pinctrl_probe(pdev); 240 240 } 241 241 242 - static int orion_pinctrl_remove(struct platform_device *pdev) 243 - { 244 - return mvebu_pinctrl_remove(pdev); 245 - } 246 - 247 242 static struct platform_driver orion_pinctrl_driver = { 248 243 .driver = { 249 244 .name = "orion-pinctrl", 250 245 .of_match_table = of_match_ptr(orion_pinctrl_of_match), 251 246 }, 252 247 .probe = orion_pinctrl_probe, 253 - .remove = orion_pinctrl_remove, 254 248 }; 255 249 256 250 module_platform_driver(orion_pinctrl_driver);