Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

regulator: lp872x: Remove warning about invalid DVS GPIO

Some devices don't hook the DVS pin to a GPIO but to ground or VCC.
In those cases, it is not a problem to have no DVS GPIO provided, as the current
code will already switch to software-only DVS selection:

When the DVS GPIO is invalid, lp872x_init_dvs jumps to the set_default_dvs_mode
label, which instructs the chip not to use the DVS pin at all and do it all in
software instead (by clearing the LP8720_EXT_DVS_M bit in the
LP872X_GENERAL_CFG register).

That is reflected later in the code, when setting the bucks (the DVS pin only
applies to the bucks) by checking for the LP8720_EXT_DVS_M bit on the
LP872X_GENERAL_CFG register (in lp872x_select_buck_vout_addr) to decide whether
to use software or hardware DVS selection.

Thus, there is no need to print a warning when the DVS GPIO is invalid.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Paul Kocialkowski and committed by
Mark Brown
690f44ba 92e963f5

+1 -3
+1 -3
drivers/regulator/lp872x.c
··· 738 738 goto set_default_dvs_mode; 739 739 740 740 gpio = dvs->gpio; 741 - if (!gpio_is_valid(gpio)) { 742 - dev_warn(lp->dev, "invalid gpio: %d\n", gpio); 741 + if (!gpio_is_valid(gpio)) 743 742 goto set_default_dvs_mode; 744 - } 745 743 746 744 pinstate = dvs->init_state; 747 745 ret = devm_gpio_request_one(lp->dev, gpio, pinstate, "LP872X DVS");