[EBTABLES]: vfree() checking cleanups

From: jlamanna@gmail.com

ebtables.c vfree() checking cleanups.

Signed-off by: James Lamanna <jlamanna@gmail.com>
Signed-off-by: Domen Puncer <domen@coderock.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by James Lamanna and committed by David S. Miller 68d31872 285b3afe

+7 -14
+7 -14
net/bridge/netfilter/ebtables.c
··· 859 859 if (repl->valid_hooks & (1 << i)) 860 860 if (check_chainloops(newinfo->hook_entry[i], 861 861 cl_s, udc_cnt, i, newinfo->entries)) { 862 - if (cl_s) 863 - vfree(cl_s); 862 + vfree(cl_s); 864 863 return -EINVAL; 865 864 } 866 865 ··· 882 883 EBT_ENTRY_ITERATE(newinfo->entries, newinfo->entries_size, 883 884 ebt_cleanup_entry, &i); 884 885 } 885 - if (cl_s) 886 - vfree(cl_s); 886 + vfree(cl_s); 887 887 return ret; 888 888 } 889 889 ··· 1028 1030 } 1029 1031 vfree(table); 1030 1032 1031 - if (counterstmp) 1032 - vfree(counterstmp); 1033 + vfree(counterstmp); 1033 1034 return ret; 1034 1035 1035 1036 free_unlock: ··· 1037 1040 EBT_ENTRY_ITERATE(newinfo->entries, newinfo->entries_size, 1038 1041 ebt_cleanup_entry, NULL); 1039 1042 free_counterstmp: 1040 - if (counterstmp) 1041 - vfree(counterstmp); 1043 + vfree(counterstmp); 1042 1044 /* can be initialized in translate_table() */ 1043 1045 if (newinfo->chainstack) { 1044 1046 for (i = 0; i < num_possible_cpus(); i++) ··· 1045 1049 vfree(newinfo->chainstack); 1046 1050 } 1047 1051 free_entries: 1048 - if (newinfo->entries) 1049 - vfree(newinfo->entries); 1052 + vfree(newinfo->entries); 1050 1053 free_newinfo: 1051 - if (newinfo) 1052 - vfree(newinfo); 1054 + vfree(newinfo); 1053 1055 return ret; 1054 1056 } 1055 1057 ··· 1207 1213 down(&ebt_mutex); 1208 1214 LIST_DELETE(&ebt_tables, table); 1209 1215 up(&ebt_mutex); 1210 - if (table->private->entries) 1211 - vfree(table->private->entries); 1216 + vfree(table->private->entries); 1212 1217 if (table->private->chainstack) { 1213 1218 for (i = 0; i < num_possible_cpus(); i++) 1214 1219 vfree(table->private->chainstack[i]);