Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

x86/asm/crypto: Don't use RBP as a scratch register

The frame pointer (RBP) is getting clobbered in
sha1_mb_mgr_submit_avx2() before a function call, which can mess up
stack traces. Use R12 instead.

Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Bernd Petrovitsch <bernd@petrovitsch.priv.at>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Chris J Arges <chris.j.arges@canonical.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jiri Slaby <jslaby@suse.cz>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Michal Marek <mmarek@suse.cz>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Pedro Alves <palves@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: live-patching@vger.kernel.org
Link: http://lkml.kernel.org/r/15a3eb7ebe68e37755927915f45e4f0bde4d18c5.1453405861.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>

authored by

Josh Poimboeuf and committed by
Ingo Molnar
68874ac3 aec4d0e3

+4 -4
+4 -4
arch/x86/crypto/sha-mb/sha1_mb_mgr_submit_avx2.S
··· 86 86 len = %rax 87 87 DWORD_len = %eax 88 88 89 - lane = %rbp 90 - tmp3 = %rbp 89 + lane = %r12 90 + tmp3 = %r12 91 91 92 92 tmp = %r9 93 93 DWORD_tmp = %r9d ··· 99 99 # arg 2 : rdx : job 100 100 ENTRY(sha1_mb_mgr_submit_avx2) 101 101 push %rbx 102 - push %rbp 102 + push %r12 103 103 104 104 mov _unused_lanes(state), unused_lanes 105 105 mov unused_lanes, lane ··· 190 190 movl DWORD_tmp, _result_digest+1*16(job_rax) 191 191 192 192 return: 193 - pop %rbp 193 + pop %r12 194 194 pop %rbx 195 195 ret 196 196