Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[PATCH] USB: UHCI: edit some comments

This patch (as615b) edits a large number of comments in the uhci-hcd code,
mainly removing excess apostrophes.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

authored by

Alan Stern and committed by
Greg Kroah-Hartman
687f5f34 fa346568

+36 -35
+6 -6
drivers/usb/host/uhci-debug.c
··· 2 2 * UHCI-specific debugging code. Invaluable when something 3 3 * goes wrong, but don't get in my face. 4 4 * 5 - * Kernel visible pointers are surrounded in []'s and bus 6 - * visible pointers are surrounded in ()'s 5 + * Kernel visible pointers are surrounded in []s and bus 6 + * visible pointers are surrounded in ()s 7 7 * 8 8 * (C) Copyright 1999 Linus Torvalds 9 9 * (C) Copyright 1999-2001 Johannes Erdfelt ··· 19 19 20 20 static struct dentry *uhci_debugfs_root = NULL; 21 21 22 - /* Handle REALLY large printk's so we don't overflow buffers */ 22 + /* Handle REALLY large printks so we don't overflow buffers */ 23 23 static inline void lprintk(char *buf) 24 24 { 25 25 char *p; ··· 160 160 } 161 161 162 162 if (active && ni > i) { 163 - out += sprintf(out, "%*s[skipped %d active TD's]\n", space, "", ni - i); 163 + out += sprintf(out, "%*s[skipped %d active TDs]\n", space, "", ni - i); 164 164 tmp = ntmp; 165 165 td = ntd; 166 166 i = ni; ··· 173 173 if (list_empty(&urbp->queue_list) || urbp->queued) 174 174 goto out; 175 175 176 - out += sprintf(out, "%*sQueued QH's:\n", -space, "--"); 176 + out += sprintf(out, "%*sQueued QHs:\n", -space, "--"); 177 177 178 178 head = &urbp->queue_list; 179 179 tmp = head->next; ··· 464 464 } while (tmp != head); 465 465 } 466 466 467 - out += sprintf(out, "Skeleton QH's\n"); 467 + out += sprintf(out, "Skeleton QHs\n"); 468 468 469 469 for (i = 0; i < UHCI_NUM_SKELQH; ++i) { 470 470 int shown = 0;
+9 -8
drivers/usb/host/uhci-hcd.c
··· 62 62 63 63 /* 64 64 * debug = 0, no debugging messages 65 - * debug = 1, dump failed URB's except for stalls 66 - * debug = 2, dump all failed URB's (including stalls) 65 + * debug = 1, dump failed URBs except for stalls 66 + * debug = 2, dump all failed URBs (including stalls) 67 67 * show all queues in /debug/uhci/[pci_addr] 68 - * debug = 3, show all TD's in URB's when dumping 68 + * debug = 3, show all TDs in URBs when dumping 69 69 */ 70 70 #ifdef DEBUG 71 71 static int debug = 1; ··· 88 88 #define FSBR_DELAY msecs_to_jiffies(50) 89 89 90 90 /* When we timeout an idle transfer for FSBR, we'll switch it over to */ 91 - /* depth first traversal. We'll do it in groups of this number of TD's */ 91 + /* depth first traversal. We'll do it in groups of this number of TDs */ 92 92 /* to make sure it doesn't hog all of the bandwidth */ 93 93 #define DEPTH_INTERVAL 5 94 94 ··· 728 728 729 729 dev_dbg(uhci_dev(uhci), "%s\n", __FUNCTION__); 730 730 731 - /* We aren't in D3 state anymore, we do that even if dead as I 732 - * really don't want to keep a stale HCD_FLAG_HW_ACCESSIBLE=0 731 + /* Since we aren't in D3 any more, it's safe to set this flag 732 + * even if the controller was dead. It might not even be dead 733 + * any more, if the firmware or quirks code has reset it. 733 734 */ 734 735 set_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags); 735 736 mb(); ··· 880 879 881 880 init_failed: 882 881 if (kmem_cache_destroy(uhci_up_cachep)) 883 - warn("not all urb_priv's were freed!"); 882 + warn("not all urb_privs were freed!"); 884 883 885 884 up_failed: 886 885 debugfs_remove(uhci_debugfs_root); ··· 898 897 pci_unregister_driver(&uhci_pci_driver); 899 898 900 899 if (kmem_cache_destroy(uhci_up_cachep)) 901 - warn("not all urb_priv's were freed!"); 900 + warn("not all urb_privs were freed!"); 902 901 903 902 debugfs_remove(uhci_debugfs_root); 904 903 kfree(errbuf);
+12 -12
drivers/usb/host/uhci-hcd.h
··· 223 223 */ 224 224 225 225 /* 226 - * The UHCI driver places Interrupt, Control and Bulk into QH's both 227 - * to group together TD's for one transfer, and also to faciliate queuing 228 - * of URB's. To make it easy to insert entries into the schedule, we have 229 - * a skeleton of QH's for each predefined Interrupt latency, low-speed 226 + * The UHCI driver places Interrupt, Control and Bulk into QHs both 227 + * to group together TDs for one transfer, and also to facilitate queuing 228 + * of URBs. To make it easy to insert entries into the schedule, we have 229 + * a skeleton of QHs for each predefined Interrupt latency, low-speed 230 230 * control, full-speed control and terminating QH (see explanation for 231 231 * the terminating QH below). 232 232 * ··· 257 257 * reclamation. 258 258 * 259 259 * Isochronous transfers are stored before the start of the skeleton 260 - * schedule and don't use QH's. While the UHCI spec doesn't forbid the 261 - * use of QH's for Isochronous, it doesn't use them either. And the spec 260 + * schedule and don't use QHs. While the UHCI spec doesn't forbid the 261 + * use of QHs for Isochronous, it doesn't use them either. And the spec 262 262 * says that queues never advance on an error completion status, which 263 263 * makes them totally unsuitable for Isochronous transfers. 264 264 */ ··· 359 359 struct dma_pool *td_pool; 360 360 361 361 struct uhci_td *term_td; /* Terminating TD, see UHCI bug */ 362 - struct uhci_qh *skelqh[UHCI_NUM_SKELQH]; /* Skeleton QH's */ 362 + struct uhci_qh *skelqh[UHCI_NUM_SKELQH]; /* Skeleton QHs */ 363 363 364 364 spinlock_t lock; 365 365 ··· 389 389 unsigned long resuming_ports; 390 390 unsigned long ports_timeout; /* Time to stop signalling */ 391 391 392 - /* Main list of URB's currently controlled by this HC */ 392 + /* Main list of URBs currently controlled by this HC */ 393 393 struct list_head urb_list; 394 394 395 - /* List of QH's that are done, but waiting to be unlinked (race) */ 395 + /* List of QHs that are done, but waiting to be unlinked (race) */ 396 396 struct list_head qh_remove_list; 397 397 unsigned int qh_remove_age; /* Age in frames */ 398 398 399 - /* List of TD's that are done, but waiting to be freed (race) */ 399 + /* List of TDs that are done, but waiting to be freed (race) */ 400 400 struct list_head td_remove_list; 401 401 unsigned int td_remove_age; /* Age in frames */ 402 402 403 - /* List of asynchronously unlinked URB's */ 403 + /* List of asynchronously unlinked URBs */ 404 404 struct list_head urb_remove_list; 405 405 unsigned int urb_remove_age; /* Age in frames */ 406 406 407 - /* List of URB's awaiting completion callback */ 407 + /* List of URBs awaiting completion callback */ 408 408 struct list_head complete_list; 409 409 410 410 int rh_numports; /* Number of root-hub ports */
+9 -9
drivers/usb/host/uhci-q.c
··· 80 80 } 81 81 82 82 /* 83 - * We insert Isochronous URB's directly into the frame list at the beginning 83 + * We insert Isochronous URBs directly into the frame list at the beginning 84 84 */ 85 85 static void uhci_insert_td_frame_list(struct uhci_hcd *uhci, struct uhci_td *td, unsigned framenum) 86 86 { ··· 369 369 uhci_fixup_toggle(urb, 370 370 uhci_toggle(td_token(lltd)) ^ 1)); 371 371 372 - /* All qh's in the queue need to link to the next queue */ 372 + /* All qhs in the queue need to link to the next queue */ 373 373 urbp->qh->link = eurbp->qh->link; 374 374 375 375 wmb(); /* Make sure we flush everything */ ··· 502 502 } 503 503 504 504 /* Check to see if the remove list is empty. Set the IOC bit */ 505 - /* to force an interrupt so we can remove the TD's*/ 505 + /* to force an interrupt so we can remove the TDs*/ 506 506 if (list_empty(&uhci->td_remove_list)) 507 507 uhci_set_next_interrupt(uhci); 508 508 ··· 612 612 } 613 613 614 614 /* 615 - * Build the DATA TD's 615 + * Build the DATA TDs 616 616 */ 617 617 while (len > 0) { 618 618 int pktsze = len; ··· 744 744 745 745 urb->actual_length = 0; 746 746 747 - /* The rest of the TD's (but the last) are data */ 747 + /* The rest of the TDs (but the last) are data */ 748 748 tmp = tmp->next; 749 749 while (tmp != head && tmp->next != head) { 750 750 unsigned int ctrlstat; ··· 848 848 status |= TD_CTRL_SPD; 849 849 850 850 /* 851 - * Build the DATA TD's 851 + * Build the DATA TDs 852 852 */ 853 853 do { /* Allow zero length packets */ 854 854 int pktsze = maxsze; ··· 1025 1025 list_for_each_entry(up, &uhci->urb_list, urb_list) { 1026 1026 struct urb *u = up->urb; 1027 1027 1028 - /* look for pending URB's with identical pipe handle */ 1028 + /* look for pending URBs with identical pipe handle */ 1029 1029 if ((urb->pipe == u->pipe) && (urb->dev == u->dev) && 1030 1030 (u->status == -EINPROGRESS) && (u != urb)) { 1031 1031 if (!last_urb) ··· 1355 1355 1356 1356 uhci_delete_queued_urb(uhci, urb); 1357 1357 1358 - /* The interrupt loop will reclaim the QH's */ 1358 + /* The interrupt loop will reclaim the QHs */ 1359 1359 uhci_remove_qh(uhci, urbp->qh); 1360 1360 urbp->qh = NULL; 1361 1361 } ··· 1413 1413 list_for_each_entry(td, head, list) { 1414 1414 /* 1415 1415 * Make sure we don't do the last one (since it'll have the 1416 - * TERM bit set) as well as we skip every so many TD's to 1416 + * TERM bit set) as well as we skip every so many TDs to 1417 1417 * make sure it doesn't hog the bandwidth 1418 1418 */ 1419 1419 if (td->list.next != head && (count % DEPTH_INTERVAL) ==