Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: drxj: make several const arrays static

Don't populate const arrays on the stack but instead make them static.
Makes the object code smaller by over 1800 bytes:

Before:
text data bss dec hex filename
94100 9160 0 103260 1935c drxj.o

After:
text data bss dec hex filename
91044 10400 0 101444 18c44 drxj.o

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

authored by

Colin Ian King and committed by
Mauro Carvalho Chehab
679cfbb1 7f033708

+18 -17
+18 -17
drivers/media/dvb-frontends/drx39xyj/drxj.c
··· 5489 5489 struct i2c_device_addr *dev_addr = NULL; 5490 5490 int rc; 5491 5491 5492 - const u8 vsb_ffe_leak_gain_ram0[] = { 5492 + static const u8 vsb_ffe_leak_gain_ram0[] = { 5493 5493 DRXJ_16TO8(0x8), /* FFETRAINLKRATIO1 */ 5494 5494 DRXJ_16TO8(0x8), /* FFETRAINLKRATIO2 */ 5495 5495 DRXJ_16TO8(0x8), /* FFETRAINLKRATIO3 */ ··· 5620 5620 DRXJ_16TO8(0x1010) /* FIRRCA1GAIN8 */ 5621 5621 }; 5622 5622 5623 - const u8 vsb_ffe_leak_gain_ram1[] = { 5623 + static const u8 vsb_ffe_leak_gain_ram1[] = { 5624 5624 DRXJ_16TO8(0x1010), /* FIRRCA1GAIN9 */ 5625 5625 DRXJ_16TO8(0x0808), /* FIRRCA1GAIN10 */ 5626 5626 DRXJ_16TO8(0x0808), /* FIRRCA1GAIN11 */ ··· 5710 5710 struct drxj_data *ext_attr = NULL; 5711 5711 u16 cmd_result = 0; 5712 5712 u16 cmd_param = 0; 5713 - const u8 vsb_taps_re[] = { 5713 + static const u8 vsb_taps_re[] = { 5714 5714 DRXJ_16TO8(-2), /* re0 */ 5715 5715 DRXJ_16TO8(4), /* re1 */ 5716 5716 DRXJ_16TO8(1), /* re2 */ ··· 6666 6666 { 6667 6667 struct i2c_device_addr *dev_addr = demod->my_i2c_dev_addr; 6668 6668 int rc; 6669 - const u8 qam_dq_qual_fun[] = { 6669 + static const u8 qam_dq_qual_fun[] = { 6670 6670 DRXJ_16TO8(2), /* fun0 */ 6671 6671 DRXJ_16TO8(2), /* fun1 */ 6672 6672 DRXJ_16TO8(2), /* fun2 */ ··· 6674 6674 DRXJ_16TO8(3), /* fun4 */ 6675 6675 DRXJ_16TO8(3), /* fun5 */ 6676 6676 }; 6677 - const u8 qam_eq_cma_rad[] = { 6677 + static const u8 qam_eq_cma_rad[] = { 6678 6678 DRXJ_16TO8(13517), /* RAD0 */ 6679 6679 DRXJ_16TO8(13517), /* RAD1 */ 6680 6680 DRXJ_16TO8(13517), /* RAD2 */ ··· 6901 6901 { 6902 6902 struct i2c_device_addr *dev_addr = demod->my_i2c_dev_addr; 6903 6903 int rc; 6904 - const u8 qam_dq_qual_fun[] = { 6904 + static const u8 qam_dq_qual_fun[] = { 6905 6905 DRXJ_16TO8(3), /* fun0 */ 6906 6906 DRXJ_16TO8(3), /* fun1 */ 6907 6907 DRXJ_16TO8(3), /* fun2 */ ··· 6909 6909 DRXJ_16TO8(4), /* fun4 */ 6910 6910 DRXJ_16TO8(4), /* fun5 */ 6911 6911 }; 6912 - const u8 qam_eq_cma_rad[] = { 6912 + static const u8 qam_eq_cma_rad[] = { 6913 6913 DRXJ_16TO8(6707), /* RAD0 */ 6914 6914 DRXJ_16TO8(6707), /* RAD1 */ 6915 6915 DRXJ_16TO8(6707), /* RAD2 */ ··· 7136 7136 { 7137 7137 struct i2c_device_addr *dev_addr = demod->my_i2c_dev_addr; 7138 7138 int rc; 7139 - const u8 qam_dq_qual_fun[] = { /* this is hw reset value. no necessary to re-write */ 7139 + static const u8 qam_dq_qual_fun[] = { 7140 + /* this is hw reset value. no necessary to re-write */ 7140 7141 DRXJ_16TO8(4), /* fun0 */ 7141 7142 DRXJ_16TO8(4), /* fun1 */ 7142 7143 DRXJ_16TO8(4), /* fun2 */ ··· 7145 7144 DRXJ_16TO8(6), /* fun4 */ 7146 7145 DRXJ_16TO8(6), /* fun5 */ 7147 7146 }; 7148 - const u8 qam_eq_cma_rad[] = { 7147 + static const u8 qam_eq_cma_rad[] = { 7149 7148 DRXJ_16TO8(13336), /* RAD0 */ 7150 7149 DRXJ_16TO8(12618), /* RAD1 */ 7151 7150 DRXJ_16TO8(11988), /* RAD2 */ ··· 7372 7371 { 7373 7372 struct i2c_device_addr *dev_addr = demod->my_i2c_dev_addr; 7374 7373 int rc; 7375 - const u8 qam_dq_qual_fun[] = { 7374 + static const u8 qam_dq_qual_fun[] = { 7376 7375 DRXJ_16TO8(6), /* fun0 */ 7377 7376 DRXJ_16TO8(6), /* fun1 */ 7378 7377 DRXJ_16TO8(6), /* fun2 */ ··· 7380 7379 DRXJ_16TO8(9), /* fun4 */ 7381 7380 DRXJ_16TO8(9), /* fun5 */ 7382 7381 }; 7383 - const u8 qam_eq_cma_rad[] = { 7382 + static const u8 qam_eq_cma_rad[] = { 7384 7383 DRXJ_16TO8(6164), /* RAD0 */ 7385 7384 DRXJ_16TO8(6598), /* RAD1 */ 7386 7385 DRXJ_16TO8(6394), /* RAD2 */ ··· 7607 7606 { 7608 7607 struct i2c_device_addr *dev_addr = demod->my_i2c_dev_addr; 7609 7608 int rc; 7610 - const u8 qam_dq_qual_fun[] = { 7609 + static const u8 qam_dq_qual_fun[] = { 7611 7610 DRXJ_16TO8(8), /* fun0 */ 7612 7611 DRXJ_16TO8(8), /* fun1 */ 7613 7612 DRXJ_16TO8(8), /* fun2 */ ··· 7615 7614 DRXJ_16TO8(12), /* fun4 */ 7616 7615 DRXJ_16TO8(12), /* fun5 */ 7617 7616 }; 7618 - const u8 qam_eq_cma_rad[] = { 7617 + static const u8 qam_eq_cma_rad[] = { 7619 7618 DRXJ_16TO8(12345), /* RAD0 */ 7620 7619 DRXJ_16TO8(12345), /* RAD1 */ 7621 7620 DRXJ_16TO8(13626), /* RAD2 */ ··· 7863 7862 /* parameter */ NULL, 7864 7863 /* result */ NULL 7865 7864 }; 7866 - const u8 qam_a_taps[] = { 7865 + static const u8 qam_a_taps[] = { 7867 7866 DRXJ_16TO8(-1), /* re0 */ 7868 7867 DRXJ_16TO8(1), /* re1 */ 7869 7868 DRXJ_16TO8(1), /* re2 */ ··· 7893 7892 DRXJ_16TO8(-40), /* re26 */ 7894 7893 DRXJ_16TO8(619) /* re27 */ 7895 7894 }; 7896 - const u8 qam_b64_taps[] = { 7895 + static const u8 qam_b64_taps[] = { 7897 7896 DRXJ_16TO8(0), /* re0 */ 7898 7897 DRXJ_16TO8(-2), /* re1 */ 7899 7898 DRXJ_16TO8(1), /* re2 */ ··· 7923 7922 DRXJ_16TO8(-46), /* re26 */ 7924 7923 DRXJ_16TO8(614) /* re27 */ 7925 7924 }; 7926 - const u8 qam_b256_taps[] = { 7925 + static const u8 qam_b256_taps[] = { 7927 7926 DRXJ_16TO8(-2), /* re0 */ 7928 7927 DRXJ_16TO8(4), /* re1 */ 7929 7928 DRXJ_16TO8(1), /* re2 */ ··· 7953 7952 DRXJ_16TO8(-32), /* re26 */ 7954 7953 DRXJ_16TO8(628) /* re27 */ 7955 7954 }; 7956 - const u8 qam_c_taps[] = { 7955 + static const u8 qam_c_taps[] = { 7957 7956 DRXJ_16TO8(-3), /* re0 */ 7958 7957 DRXJ_16TO8(3), /* re1 */ 7959 7958 DRXJ_16TO8(2), /* re2 */