Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: pm8001: Use sysfs_emit() in show function callbacks

According to Documentation/filesystems/sysfs.rst, the show() callback
function of kobject attributes should use sysfs_emit() instead of the
sprintf() family of functions.

Issue identified using the coccinelle device_attr_show.cocci script.

Link: https://lore.kernel.org/r/Y5JE/xI2NNbnox/A@qemulion
Signed-off-by: Deepak R Varma <drv@mailo.com>
Acked-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Deepak R Varma and committed by
Martin K. Petersen
679062c6 d058bea1

+21 -25
+21 -25
drivers/scsi/pm8001/pm8001_ctl.c
··· 61 61 struct pm8001_hba_info *pm8001_ha = sha->lldd_ha; 62 62 63 63 if (pm8001_ha->chip_id == chip_8001) { 64 - return snprintf(buf, PAGE_SIZE, "%d\n", 64 + return sysfs_emit(buf, "%d\n", 65 65 pm8001_ha->main_cfg_tbl.pm8001_tbl.interface_rev); 66 66 } else { 67 - return snprintf(buf, PAGE_SIZE, "%d\n", 67 + return sysfs_emit(buf, "%d\n", 68 68 pm8001_ha->main_cfg_tbl.pm80xx_tbl.interface_rev); 69 69 } 70 70 } ··· 86 86 struct sas_ha_struct *sha = SHOST_TO_SAS_HA(shost); 87 87 struct pm8001_hba_info *pm8001_ha = sha->lldd_ha; 88 88 89 - return snprintf(buf, PAGE_SIZE, "%d\n", 89 + return sysfs_emit(buf, "%d\n", 90 90 pm8001_ha->controller_fatal_error); 91 91 } 92 92 static DEVICE_ATTR_RO(controller_fatal_error); ··· 107 107 struct pm8001_hba_info *pm8001_ha = sha->lldd_ha; 108 108 109 109 if (pm8001_ha->chip_id == chip_8001) { 110 - return snprintf(buf, PAGE_SIZE, "%02x.%02x.%02x.%02x\n", 110 + return sysfs_emit(buf, "%02x.%02x.%02x.%02x\n", 111 111 (u8)(pm8001_ha->main_cfg_tbl.pm8001_tbl.firmware_rev >> 24), 112 112 (u8)(pm8001_ha->main_cfg_tbl.pm8001_tbl.firmware_rev >> 16), 113 113 (u8)(pm8001_ha->main_cfg_tbl.pm8001_tbl.firmware_rev >> 8), 114 114 (u8)(pm8001_ha->main_cfg_tbl.pm8001_tbl.firmware_rev)); 115 115 } else { 116 - return snprintf(buf, PAGE_SIZE, "%02x.%02x.%02x.%02x\n", 116 + return sysfs_emit(buf, "%02x.%02x.%02x.%02x\n", 117 117 (u8)(pm8001_ha->main_cfg_tbl.pm80xx_tbl.firmware_rev >> 24), 118 118 (u8)(pm8001_ha->main_cfg_tbl.pm80xx_tbl.firmware_rev >> 16), 119 119 (u8)(pm8001_ha->main_cfg_tbl.pm80xx_tbl.firmware_rev >> 8), ··· 138 138 struct pm8001_hba_info *pm8001_ha = sha->lldd_ha; 139 139 140 140 if (pm8001_ha->chip_id != chip_8001) { 141 - return snprintf(buf, PAGE_SIZE, "%02x.%02x.%02x.%02x\n", 141 + return sysfs_emit(buf, "%02x.%02x.%02x.%02x\n", 142 142 (u8)(pm8001_ha->main_cfg_tbl.pm80xx_tbl.ila_version >> 24), 143 143 (u8)(pm8001_ha->main_cfg_tbl.pm80xx_tbl.ila_version >> 16), 144 144 (u8)(pm8001_ha->main_cfg_tbl.pm80xx_tbl.ila_version >> 8), ··· 164 164 struct pm8001_hba_info *pm8001_ha = sha->lldd_ha; 165 165 166 166 if (pm8001_ha->chip_id != chip_8001) { 167 - return snprintf(buf, PAGE_SIZE, "%02x.%02x.%02x.%02x\n", 167 + return sysfs_emit(buf, "%02x.%02x.%02x.%02x\n", 168 168 (u8)(pm8001_ha->main_cfg_tbl.pm80xx_tbl.inc_fw_version >> 24), 169 169 (u8)(pm8001_ha->main_cfg_tbl.pm80xx_tbl.inc_fw_version >> 16), 170 170 (u8)(pm8001_ha->main_cfg_tbl.pm80xx_tbl.inc_fw_version >> 8), ··· 191 191 struct pm8001_hba_info *pm8001_ha = sha->lldd_ha; 192 192 193 193 if (pm8001_ha->chip_id == chip_8001) { 194 - return snprintf(buf, PAGE_SIZE, "%d\n", 194 + return sysfs_emit(buf, "%d\n", 195 195 pm8001_ha->main_cfg_tbl.pm8001_tbl.max_out_io); 196 196 } else { 197 - return snprintf(buf, PAGE_SIZE, "%d\n", 197 + return sysfs_emit(buf, "%d\n", 198 198 pm8001_ha->main_cfg_tbl.pm80xx_tbl.max_out_io); 199 199 } 200 200 } ··· 215 215 struct pm8001_hba_info *pm8001_ha = sha->lldd_ha; 216 216 217 217 if (pm8001_ha->chip_id == chip_8001) { 218 - return snprintf(buf, PAGE_SIZE, "%04d\n", 219 - (u16)(pm8001_ha->main_cfg_tbl.pm8001_tbl.max_sgl >> 16) 220 - ); 218 + return sysfs_emit(buf, "%04d\n", 219 + (u16)(pm8001_ha->main_cfg_tbl.pm8001_tbl.max_sgl >> 16)); 221 220 } else { 222 - return snprintf(buf, PAGE_SIZE, "%04d\n", 223 - (u16)(pm8001_ha->main_cfg_tbl.pm80xx_tbl.max_sgl >> 16) 224 - ); 221 + return sysfs_emit(buf, "%04d\n", 222 + (u16)(pm8001_ha->main_cfg_tbl.pm80xx_tbl.max_sgl >> 16)); 225 223 } 226 224 } 227 225 static DEVICE_ATTR(max_devices, S_IRUGO, pm8001_ctl_max_devices_show, NULL); ··· 240 242 struct pm8001_hba_info *pm8001_ha = sha->lldd_ha; 241 243 242 244 if (pm8001_ha->chip_id == chip_8001) { 243 - return snprintf(buf, PAGE_SIZE, "%04d\n", 244 - pm8001_ha->main_cfg_tbl.pm8001_tbl.max_sgl & 0x0000FFFF 245 - ); 245 + return sysfs_emit(buf, "%04d\n", 246 + pm8001_ha->main_cfg_tbl.pm8001_tbl.max_sgl & 0x0000FFFF); 246 247 } else { 247 - return snprintf(buf, PAGE_SIZE, "%04d\n", 248 - pm8001_ha->main_cfg_tbl.pm80xx_tbl.max_sgl & 0x0000FFFF 249 - ); 248 + return sysfs_emit(buf, "%04d\n", 249 + pm8001_ha->main_cfg_tbl.pm80xx_tbl.max_sgl & 0x0000FFFF); 250 250 } 251 251 } 252 252 static DEVICE_ATTR(max_sg_list, S_IRUGO, pm8001_ctl_max_sg_list_show, NULL); ··· 311 315 struct Scsi_Host *shost = class_to_shost(cdev); 312 316 struct sas_ha_struct *sha = SHOST_TO_SAS_HA(shost); 313 317 struct pm8001_hba_info *pm8001_ha = sha->lldd_ha; 314 - return snprintf(buf, PAGE_SIZE, "0x%016llx\n", 318 + return sysfs_emit(buf, "0x%016llx\n", 315 319 be64_to_cpu(*(__be64 *)pm8001_ha->sas_addr)); 316 320 } 317 321 static DEVICE_ATTR(host_sas_address, S_IRUGO, ··· 332 336 struct sas_ha_struct *sha = SHOST_TO_SAS_HA(shost); 333 337 struct pm8001_hba_info *pm8001_ha = sha->lldd_ha; 334 338 335 - return snprintf(buf, PAGE_SIZE, "%08xh\n", pm8001_ha->logging_level); 339 + return sysfs_emit(buf, "%08xh\n", pm8001_ha->logging_level); 336 340 } 337 341 338 342 static ssize_t pm8001_ctl_logging_level_store(struct device *cdev, ··· 513 517 struct sas_ha_struct *sha = SHOST_TO_SAS_HA(shost); 514 518 struct pm8001_hba_info *pm8001_ha = sha->lldd_ha; 515 519 516 - return snprintf(buf, PAGE_SIZE, "%d\n", 520 + return sysfs_emit(buf, "%d\n", 517 521 pm8001_ha->main_cfg_tbl.pm80xx_tbl.event_log_size); 518 522 } 519 523 static DEVICE_ATTR_RO(event_log_size); ··· 600 604 struct sas_ha_struct *sha = SHOST_TO_SAS_HA(shost); 601 605 struct pm8001_hba_info *pm8001_ha = sha->lldd_ha; 602 606 603 - return snprintf(buf, PAGE_SIZE, "%08x", 607 + return sysfs_emit(buf, "%08x\n", 604 608 pm8001_ha->non_fatal_count); 605 609 } 606 610