Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

spi: core and gpio expanders use subsys_init

Make the SPI external GPIO expander drivers register themselves at
subsys_initcall() time when they're statically linked, and make the SPI
core do its driver model initialization earlier so that's safe.

SOC-integrated GPIOs are available starting very early -- often before
initcalls start to run, or earily in arch_initcall() at latest -- so this
improves consistency, letting more subsystems rely on GPIOs being usable
by their own subsys_initcall() code.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

David Brownell and committed by
Linus Torvalds
673c0c00 2bec19fe

+9 -4
+4 -2
drivers/gpio/max7301.c
··· 325 325 { 326 326 return spi_register_driver(&max7301_driver); 327 327 } 328 + /* register after spi postcore initcall and before 329 + * subsys initcalls that may rely on these GPIOs 330 + */ 331 + subsys_initcall(max7301_init); 328 332 329 333 static void __exit max7301_exit(void) 330 334 { 331 335 spi_unregister_driver(&max7301_driver); 332 336 } 333 - 334 - module_init(max7301_init); 335 337 module_exit(max7301_exit); 336 338 337 339 MODULE_AUTHOR("Juergen Beisert");
+4 -1
drivers/gpio/mcp23s08.c
··· 419 419 { 420 420 return spi_register_driver(&mcp23s08_driver); 421 421 } 422 - module_init(mcp23s08_init); 422 + /* register after spi postcore initcall and before 423 + * subsys initcalls that may rely on these GPIOs 424 + */ 425 + subsys_initcall(mcp23s08_init); 423 426 424 427 static void __exit mcp23s08_exit(void) 425 428 {
+1 -1
drivers/spi/spi.c
··· 738 738 * driver registration) _could_ be dynamically linked (modular) ... costs 739 739 * include needing to have boardinfo data structures be much more public. 740 740 */ 741 - subsys_initcall(spi_init); 741 + postcore_initcall(spi_init); 742 742