s390/lcs: fix variable dereferenced before check

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

smatch complains about
drivers/s390/net/lcs.c:1741 lcs_get_control() warn: variable dereferenced before check 'card->dev' (see line 1739)

Fixes: 27eb5ac8f015 ("[PATCH] s390: lcs driver bug fixes and improvements [1/2]")
Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Alexandra Winter and committed by

David S. Miller 3 years ago 671bb35c 0c0b2058

+4 -3

1 changed file

expand all

drivers

s390

net

lcs.c

+4 -3

drivers/s390/net/lcs.c

··· 1736 1736 lcs_schedule_recovery(card); 1737 1737 break; 1738 1738 case LCS_CMD_STOPLAN: 1739 - pr_warn("Stoplan for %s initiated by LGW\n", 1740 - card->dev->name); 1741 - if (card->dev) 1739 + if (card->dev) { 1740 + pr_warn("Stoplan for %s initiated by LGW\n", 1741 + card->dev->name); 1742 1742 netif_carrier_off(card->dev); 1743 + } 1743 1744 break; 1744 1745 default: 1745 1746 LCS_DBF_TEXT(5, trace, "noLGWcmd");