Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/i915: Assorted INTEL_INFO(dev) cleanups

A bunch of source files with just a few instances of the
incorrect INTEL_INFO use.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

+32 -42
+2 -3
drivers/gpu/drm/i915/intel_color.c
··· 95 95 static void i9xx_load_csc_matrix(struct drm_crtc_state *crtc_state) 96 96 { 97 97 struct drm_crtc *crtc = crtc_state->crtc; 98 - struct drm_device *dev = crtc->dev; 99 - struct drm_i915_private *dev_priv = to_i915(dev); 98 + struct drm_i915_private *dev_priv = to_i915(crtc->dev); 100 99 struct intel_crtc *intel_crtc = to_intel_crtc(crtc); 101 100 int i, pipe = intel_crtc->pipe; 102 101 uint16_t coeffs[9] = { 0, }; ··· 179 180 I915_WRITE(PIPE_CSC_PREOFF_ME(pipe), 0); 180 181 I915_WRITE(PIPE_CSC_PREOFF_LO(pipe), 0); 181 182 182 - if (INTEL_INFO(dev)->gen > 6) { 183 + if (INTEL_GEN(dev_priv) > 6) { 183 184 uint16_t postoff = 0; 184 185 185 186 if (intel_crtc_state->limited_color_range)
+6 -9
drivers/gpu/drm/i915/intel_crt.c
··· 147 147 struct intel_crtc_state *crtc_state, 148 148 int mode) 149 149 { 150 - struct drm_device *dev = encoder->base.dev; 151 - struct drm_i915_private *dev_priv = to_i915(dev); 150 + struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); 152 151 struct intel_crt *crt = intel_encoder_to_crt(encoder); 153 152 struct intel_crtc *crtc = to_intel_crtc(crtc_state->base.crtc); 154 153 const struct drm_display_mode *adjusted_mode = &crtc_state->base.adjusted_mode; 155 154 u32 adpa; 156 155 157 - if (INTEL_INFO(dev)->gen >= 5) 156 + if (INTEL_GEN(dev_priv) >= 5) 158 157 adpa = ADPA_HOTPLUG_BITS; 159 158 else 160 159 adpa = 0; ··· 672 673 static enum drm_connector_status 673 674 intel_crt_detect(struct drm_connector *connector, bool force) 674 675 { 675 - struct drm_device *dev = connector->dev; 676 - struct drm_i915_private *dev_priv = to_i915(dev); 676 + struct drm_i915_private *dev_priv = to_i915(connector->dev); 677 677 struct intel_crt *crt = intel_attached_crt(connector); 678 678 struct intel_encoder *intel_encoder = &crt->base; 679 679 enum intel_display_power_domain power_domain; ··· 729 731 if (intel_get_load_detect_pipe(connector, NULL, &tmp, &ctx)) { 730 732 if (intel_crt_detect_ddc(connector)) 731 733 status = connector_status_connected; 732 - else if (INTEL_INFO(dev)->gen < 4) 734 + else if (INTEL_GEN(dev_priv) < 4) 733 735 status = intel_crt_load_detect(crt, 734 736 to_intel_crtc(connector->state->crtc)->pipe); 735 737 else if (i915.load_detect_test) ··· 791 793 792 794 void intel_crt_reset(struct drm_encoder *encoder) 793 795 { 794 - struct drm_device *dev = encoder->dev; 795 - struct drm_i915_private *dev_priv = to_i915(dev); 796 + struct drm_i915_private *dev_priv = to_i915(encoder->dev); 796 797 struct intel_crt *crt = intel_encoder_to_crt(to_intel_encoder(encoder)); 797 798 798 - if (INTEL_INFO(dev)->gen >= 5) { 799 + if (INTEL_GEN(dev_priv) >= 5) { 799 800 u32 adpa; 800 801 801 802 adpa = I915_READ(crt->adpa_reg);
+4 -6
drivers/gpu/drm/i915/intel_ddi.c
··· 1753 1753 struct drm_connector_state *old_conn_state) 1754 1754 { 1755 1755 struct drm_encoder *encoder = &intel_encoder->base; 1756 - struct drm_device *dev = encoder->dev; 1757 - struct drm_i915_private *dev_priv = to_i915(dev); 1756 + struct drm_i915_private *dev_priv = to_i915(encoder->dev); 1758 1757 enum port port = intel_ddi_get_encoder_port(intel_encoder); 1759 1758 int type = intel_encoder->type; 1760 1759 uint32_t val; ··· 1786 1787 if (IS_SKYLAKE(dev_priv) || IS_KABYLAKE(dev_priv)) 1787 1788 I915_WRITE(DPLL_CTRL2, (I915_READ(DPLL_CTRL2) | 1788 1789 DPLL_CTRL2_DDI_CLK_OFF(port))); 1789 - else if (INTEL_INFO(dev)->gen < 9) 1790 + else if (INTEL_GEN(dev_priv) < 9) 1790 1791 I915_WRITE(PORT_CLK_SEL(port), PORT_CLK_SEL_NONE); 1791 1792 1792 1793 if (type == INTEL_OUTPUT_HDMI) { ··· 1836 1837 struct drm_encoder *encoder = &intel_encoder->base; 1837 1838 struct drm_crtc *crtc = encoder->crtc; 1838 1839 struct intel_crtc *intel_crtc = to_intel_crtc(crtc); 1839 - struct drm_device *dev = encoder->dev; 1840 - struct drm_i915_private *dev_priv = to_i915(dev); 1840 + struct drm_i915_private *dev_priv = to_i915(encoder->dev); 1841 1841 enum port port = intel_ddi_get_encoder_port(intel_encoder); 1842 1842 int type = intel_encoder->type; 1843 1843 ··· 1854 1856 } else if (type == INTEL_OUTPUT_EDP) { 1855 1857 struct intel_dp *intel_dp = enc_to_intel_dp(encoder); 1856 1858 1857 - if (port == PORT_A && INTEL_INFO(dev)->gen < 9) 1859 + if (port == PORT_A && INTEL_GEN(dev_priv) < 9) 1858 1860 intel_dp_stop_link_train(intel_dp); 1859 1861 1860 1862 intel_edp_backlight_on(intel_dp);
+2 -3
drivers/gpu/drm/i915/intel_dpll_mgr.c
··· 188 188 189 189 void intel_disable_shared_dpll(struct intel_crtc *crtc) 190 190 { 191 - struct drm_device *dev = crtc->base.dev; 192 - struct drm_i915_private *dev_priv = to_i915(dev); 191 + struct drm_i915_private *dev_priv = to_i915(crtc->base.dev); 193 192 struct intel_shared_dpll *pll = crtc->config->shared_dpll; 194 193 unsigned crtc_mask = 1 << drm_crtc_index(&crtc->base); 195 194 196 195 /* PCH only available on ILK+ */ 197 - if (INTEL_INFO(dev)->gen < 5) 196 + if (INTEL_GEN(dev_priv) < 5) 198 197 return; 199 198 200 199 if (pll == NULL)
+3 -4
drivers/gpu/drm/i915/intel_lvds.c
··· 122 122 static void intel_lvds_get_config(struct intel_encoder *encoder, 123 123 struct intel_crtc_state *pipe_config) 124 124 { 125 - struct drm_device *dev = encoder->base.dev; 126 - struct drm_i915_private *dev_priv = to_i915(dev); 125 + struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); 127 126 struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base); 128 127 u32 tmp, flags = 0; 129 128 ··· 138 139 139 140 pipe_config->base.adjusted_mode.flags |= flags; 140 141 141 - if (INTEL_INFO(dev)->gen < 5) 142 + if (INTEL_GEN(dev_priv) < 5) 142 143 pipe_config->gmch_pfit.lvds_border_bits = 143 144 tmp & LVDS_BORDER_ENABLE; 144 145 145 146 /* gen2/3 store dither state in pfit control, needs to match */ 146 - if (INTEL_INFO(dev)->gen < 4) { 147 + if (INTEL_GEN(dev_priv) < 4) { 147 148 tmp = I915_READ(PFIT_CONTROL); 148 149 149 150 pipe_config->gmch_pfit.control |= tmp & PANEL_8TO6_DITHER_ENABLE;
+5 -5
drivers/gpu/drm/i915/intel_panel.c
··· 304 304 struct intel_crtc_state *pipe_config, 305 305 int fitting_mode) 306 306 { 307 - struct drm_device *dev = intel_crtc->base.dev; 307 + struct drm_i915_private *dev_priv = to_i915(intel_crtc->base.dev); 308 308 u32 pfit_control = 0, pfit_pgm_ratios = 0, border = 0; 309 309 struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode; 310 310 ··· 325 325 break; 326 326 case DRM_MODE_SCALE_ASPECT: 327 327 /* Scale but preserve the aspect ratio */ 328 - if (INTEL_INFO(dev)->gen >= 4) 328 + if (INTEL_GEN(dev_priv) >= 4) 329 329 i965_scale_aspect(pipe_config, &pfit_control); 330 330 else 331 331 i9xx_scale_aspect(pipe_config, &pfit_control, ··· 339 339 if (pipe_config->pipe_src_h != adjusted_mode->crtc_vdisplay || 340 340 pipe_config->pipe_src_w != adjusted_mode->crtc_hdisplay) { 341 341 pfit_control |= PFIT_ENABLE; 342 - if (INTEL_INFO(dev)->gen >= 4) 342 + if (INTEL_GEN(dev_priv) >= 4) 343 343 pfit_control |= PFIT_SCALING_AUTO; 344 344 else 345 345 pfit_control |= (VERT_AUTO_SCALE | ··· 355 355 356 356 /* 965+ wants fuzzy fitting */ 357 357 /* FIXME: handle multiple panels by failing gracefully */ 358 - if (INTEL_INFO(dev)->gen >= 4) 358 + if (INTEL_GEN(dev_priv) >= 4) 359 359 pfit_control |= ((intel_crtc->pipe << PFIT_PIPE_SHIFT) | 360 360 PFIT_FILTER_FUZZY); 361 361 ··· 366 366 } 367 367 368 368 /* Make sure pre-965 set dither correctly for 18bpp panels. */ 369 - if (INTEL_INFO(dev)->gen < 4 && pipe_config->pipe_bpp == 18) 369 + if (INTEL_GEN(dev_priv) < 4 && pipe_config->pipe_bpp == 18) 370 370 pfit_control |= PANEL_8TO6_DITHER_ENABLE; 371 371 372 372 pipe_config->gmch_pfit.control = pfit_control;
+2 -2
drivers/gpu/drm/i915/intel_psr.c
··· 472 472 /* Enable PSR on the panel */ 473 473 hsw_psr_enable_sink(intel_dp); 474 474 475 - if (INTEL_INFO(dev)->gen >= 9) 475 + if (INTEL_GEN(dev_priv) >= 9) 476 476 intel_psr_activate(intel_dp); 477 477 } else { 478 478 vlv_psr_setup_vsc(intel_dp); ··· 498 498 * - On HSW/BDW we get a recoverable frozen screen until next 499 499 * exit-activate sequence. 500 500 */ 501 - if (INTEL_INFO(dev)->gen < 9) 501 + if (INTEL_GEN(dev_priv) < 9) 502 502 schedule_delayed_work(&dev_priv->psr.work, 503 503 msecs_to_jiffies(intel_dp->panel_power_cycle_delay * 5)); 504 504
+5 -6
drivers/gpu/drm/i915/intel_sdvo.c
··· 1195 1195 struct intel_crtc_state *crtc_state, 1196 1196 struct drm_connector_state *conn_state) 1197 1197 { 1198 - struct drm_device *dev = intel_encoder->base.dev; 1199 - struct drm_i915_private *dev_priv = to_i915(dev); 1198 + struct drm_i915_private *dev_priv = to_i915(intel_encoder->base.dev); 1200 1199 struct intel_crtc *crtc = to_intel_crtc(crtc_state->base.crtc); 1201 1200 const struct drm_display_mode *adjusted_mode = &crtc_state->base.adjusted_mode; 1202 1201 struct drm_display_mode *mode = &crtc_state->base.mode; ··· 1268 1269 return; 1269 1270 1270 1271 /* Set the SDVO control regs. */ 1271 - if (INTEL_INFO(dev)->gen >= 4) { 1272 + if (INTEL_GEN(dev_priv) >= 4) { 1272 1273 /* The real mode polarity is set by the SDVO commands, using 1273 1274 * struct intel_sdvo_dtd. */ 1274 1275 sdvox = SDVO_VSYNC_ACTIVE_HIGH | SDVO_HSYNC_ACTIVE_HIGH; 1275 1276 if (!HAS_PCH_SPLIT(dev_priv) && crtc_state->limited_color_range) 1276 1277 sdvox |= HDMI_COLOR_RANGE_16_235; 1277 - if (INTEL_INFO(dev)->gen < 5) 1278 + if (INTEL_GEN(dev_priv) < 5) 1278 1279 sdvox |= SDVO_BORDER_ENABLE; 1279 1280 } else { 1280 1281 sdvox = I915_READ(intel_sdvo->sdvo_reg); ··· 1293 1294 if (intel_sdvo->has_hdmi_audio) 1294 1295 sdvox |= SDVO_AUDIO_ENABLE; 1295 1296 1296 - if (INTEL_INFO(dev)->gen >= 4) { 1297 + if (INTEL_GEN(dev_priv) >= 4) { 1297 1298 /* done in crtc_mode_set as the dpll_md reg must be written early */ 1298 1299 } else if (IS_I945G(dev_priv) || IS_I945GM(dev_priv) || 1299 1300 IS_G33(dev_priv)) { ··· 1304 1305 } 1305 1306 1306 1307 if (input_dtd.part2.sdvo_flags & SDVO_NEED_TO_STALL && 1307 - INTEL_INFO(dev)->gen < 5) 1308 + INTEL_GEN(dev_priv) < 5) 1308 1309 sdvox |= SDVO_STALL_SELECT; 1309 1310 intel_sdvo_write_sdvox(intel_sdvo, sdvox); 1310 1311 }
+2 -3
drivers/gpu/drm/i915/intel_tv.c
··· 1029 1029 struct intel_crtc_state *pipe_config, 1030 1030 struct drm_connector_state *conn_state) 1031 1031 { 1032 - struct drm_device *dev = encoder->base.dev; 1033 - struct drm_i915_private *dev_priv = to_i915(dev); 1032 + struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); 1034 1033 struct intel_crtc *intel_crtc = to_intel_crtc(encoder->base.crtc); 1035 1034 struct intel_tv *intel_tv = enc_to_tv(encoder); 1036 1035 const struct tv_mode *tv_mode = intel_tv_mode_find(intel_tv); ··· 1115 1116 1116 1117 set_color_conversion(dev_priv, color_conversion); 1117 1118 1118 - if (INTEL_INFO(dev)->gen >= 4) 1119 + if (INTEL_GEN(dev_priv) >= 4) 1119 1120 I915_WRITE(TV_CLR_KNOBS, 0x00404000); 1120 1121 else 1121 1122 I915_WRITE(TV_CLR_KNOBS, 0x00606000);
+1 -1
drivers/gpu/drm/i915/intel_uncore.c
··· 1483 1483 1484 1484 for (i = 0; i < ARRAY_SIZE(whitelist); i++, entry++) { 1485 1485 if (i915_mmio_reg_offset(entry->offset_ldw) == (reg->offset & -entry->size) && 1486 - (INTEL_INFO(dev)->gen_mask & entry->gen_bitmask)) 1486 + (INTEL_INFO(dev_priv)->gen_mask & entry->gen_bitmask)) 1487 1487 break; 1488 1488 } 1489 1489