Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork

Configure Feed

Select the types of activity you want to include in your feed.

floppy: Do not copy a kernel pointer to user memory in FDGETPRM ioctl

The final field of a floppy_struct is the field "name", which is a pointer
to a string in kernel memory. The kernel pointer should not be copied to
user memory. The FDGETPRM ioctl copies a floppy_struct to user memory,
including this "name" field. This pointer cannot be used by the user
and it will leak a kernel address to user-space, which will reveal the
location of kernel code and data and undermine KASLR protection.

Model this code after the compat ioctl which copies the returned data
to a previously cleared temporary structure on the stack (excluding the
name pointer) and copy out to userspace from there. As we already have
an inparam union with an appropriate member and that memory is already
cleared even for read only calls make use of that as a temporary store.

Based on an initial patch by Brian Belleville.

CVE-2018-7755
Signed-off-by: Andy Whitcroft <apw@canonical.com>

Broke up long line.

Signed-off-by: Jens Axboe <axboe@kernel.dk>

authored by

Andy Whitcroft and committed by
Jens Axboe
65eea8ed 7ce5c8cd

+3
+3
drivers/block/floppy.c
··· 3467 3467 (struct floppy_struct **)&outparam); 3468 3468 if (ret) 3469 3469 return ret; 3470 + memcpy(&inparam.g, outparam, 3471 + offsetof(struct floppy_struct, name)); 3472 + outparam = &inparam.g; 3470 3473 break; 3471 3474 case FDMSGON: 3472 3475 UDP->flags |= FTD_MSG;