Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/r128: Fix undefined behavior due to shift overflowing the constant

Fix:

drivers/gpu/drm/r128/r128_cce.c: In function ‘r128_do_init_cce’:
drivers/gpu/drm/r128/r128_cce.c:417:2: error: case label does not reduce to an integer constant
case R128_PM4_64BM_64VCBM_64INDBM:
^~~~
drivers/gpu/drm/r128/r128_cce.c:418:2: error: case label does not reduce to an integer constant
case R128_PM4_64PIO_64VCPIO_64INDPIO:
^~~~

See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory
details as to why it triggers with older gccs only.

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20220405151517.29753-5-bp@alien8.de

authored by

Borislav Petkov and committed by
Daniel Vetter
6556551f 0b4c48f3

+2 -2
+2 -2
drivers/gpu/drm/r128/r128_drv.h
··· 300 300 # define R128_PM4_64PIO_128INDBM (5 << 28) 301 301 # define R128_PM4_64BM_128INDBM (6 << 28) 302 302 # define R128_PM4_64PIO_64VCBM_64INDBM (7 << 28) 303 - # define R128_PM4_64BM_64VCBM_64INDBM (8 << 28) 304 - # define R128_PM4_64PIO_64VCPIO_64INDPIO (15 << 28) 303 + # define R128_PM4_64BM_64VCBM_64INDBM (8U << 28) 304 + # define R128_PM4_64PIO_64VCPIO_64INDPIO (15U << 28) 305 305 # define R128_PM4_BUFFER_CNTL_NOUPDATE (1 << 27) 306 306 307 307 #define R128_PM4_BUFFER_WM_CNTL 0x0708