tjh.dev
Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
rtc: s35390a: let the core handle the alarm resolution
Tell the RTC core UIE are not supported because the resolution of the alarm
is a minute.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20211107225458.111068-2-alexandre.belloni@bootlin.com
+2
-5
+2
-5
drivers/rtc/rtc-s35390a.c
+2
-5
drivers/rtc/rtc-s35390a.c
···
285
285
alm->time.tm_min, alm->time.tm_hour, alm->time.tm_mday,
286
286
alm->time.tm_mon, alm->time.tm_year, alm->time.tm_wday);
287
287
288
-
if (alm->time.tm_sec != 0)
289
-
dev_warn(&client->dev, "Alarms are only supported on a per minute basis!\n");
290
-
291
288
/* disable interrupt (which deasserts the irq line) */
292
289
err = s35390a_set_reg(s35390a, S35390A_CMD_STATUS2, &sts, sizeof(sts));
293
290
if (err < 0)
···
488
491
s35390a->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000;
489
492
s35390a->rtc->range_max = RTC_TIMESTAMP_END_2099;
490
493
491
-
/* supports per-minute alarms only, therefore set uie_unsupported */
492
-
s35390a->rtc->uie_unsupported = 1;
494
+
set_bit(RTC_FEATURE_ALARM_RES_MINUTE, s35390a->rtc->features);
495
+
clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, s35390a->rtc->features );
493
496
494
497
if (status1 & S35390A_FLAG_INT2)
495
498
rtc_update_irq(s35390a->rtc, 1, RTC_AF);