Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mtd: mtd_oobtest: Remove redundant assignment to err

Variable err is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.

Cleans up the following clang-analyzer warning:

drivers/mtd/tests/oobtest.c:626:4: warning: Value stored to 'err' is
never read [clang-analyzer-deadcode.DeadStores].

drivers/mtd/tests/oobtest.c:603:4: warning: Value stored to 'err' is
never read [clang-analyzer-deadcode.DeadStores].

drivers/mtd/tests/oobtest.c:579:4: warning: Value stored to 'err' is
never read [clang-analyzer-deadcode.DeadStores].

drivers/mtd/tests/oobtest.c:556:4: warning: Value stored to 'err' is
never read [clang-analyzer-deadcode.DeadStores].

drivers/mtd/tests/oobtest.c:532:3: warning: Value stored to 'err' is
never read [clang-analyzer-deadcode.DeadStores].

drivers/mtd/tests/oobtest.c:509:3: warning: Value stored to 'err' is
never read [clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/1619346498-43617-1-git-send-email-jiapeng.chong@linux.alibaba.com

authored by

Jiapeng Chong and committed by
Miquel Raynal
6500dc2b 4b361cfa

-6
-6
drivers/mtd/tests/oobtest.c
··· 506 506 err = mtd_write_oob(mtd, addr0, &ops); 507 507 if (err) { 508 508 pr_info("error occurred as expected\n"); 509 - err = 0; 510 509 } else { 511 510 pr_err("error: can write past end of OOB\n"); 512 511 errcnt += 1; ··· 528 529 529 530 if (err) { 530 531 pr_info("error occurred as expected\n"); 531 - err = 0; 532 532 } else { 533 533 pr_err("error: can read past end of OOB\n"); 534 534 errcnt += 1; ··· 551 553 err = mtd_write_oob(mtd, mtd->size - mtd->writesize, &ops); 552 554 if (err) { 553 555 pr_info("error occurred as expected\n"); 554 - err = 0; 555 556 } else { 556 557 pr_err("error: wrote past end of device\n"); 557 558 errcnt += 1; ··· 573 576 574 577 if (err) { 575 578 pr_info("error occurred as expected\n"); 576 - err = 0; 577 579 } else { 578 580 pr_err("error: read past end of device\n"); 579 581 errcnt += 1; ··· 596 600 err = mtd_write_oob(mtd, mtd->size - mtd->writesize, &ops); 597 601 if (err) { 598 602 pr_info("error occurred as expected\n"); 599 - err = 0; 600 603 } else { 601 604 pr_err("error: wrote past end of device\n"); 602 605 errcnt += 1; ··· 618 623 619 624 if (err) { 620 625 pr_info("error occurred as expected\n"); 621 - err = 0; 622 626 } else { 623 627 pr_err("error: read past end of device\n"); 624 628 errcnt += 1;