net: linkwatch: add net device refcount tracker

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

Add a netdevice_tracker inside struct net_device, to track
the self reference when a device is in lweventlist.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Eric Dumazet and committed by

Jakub Kicinski 4 years ago 63f13937 606509f2

+4 -2

2 changed files

expand all

include

linux

netdevice.h

net

core

link_watch.c

include/linux/netdevice.h

··· 1950 1950 * keep a list of interfaces to be deleted. 1951 1951 * 1952 1952 * @dev_addr_shadow: Copy of @dev_addr to catch direct writes. 1953 + * @linkwatch_dev_tracker: refcount tracker used by linkwatch. 1953 1954 * 1954 1955 * FIXME: cleanup struct net_device such that network protocol info 1955 1956 * moves out. ··· 2281 2280 struct bpf_xdp_entity xdp_state[__MAX_XDP_MODE]; 2282 2281 2283 2282 u8 dev_addr_shadow[MAX_ADDR_LEN]; 2283 + netdevice_tracker linkwatch_dev_tracker; 2284 2284 }; 2285 2285 #define to_net_dev(d) container_of(d, struct net_device, dev) 2286 2286

+2 -2

net/core/link_watch.c

··· 109 109 spin_lock_irqsave(&lweventlist_lock, flags); 110 110 if (list_empty(&dev->link_watch_list)) { 111 111 list_add_tail(&dev->link_watch_list, &lweventlist); 112 - dev_hold(dev); 112 + dev_hold_track(dev, &dev->linkwatch_dev_tracker, GFP_ATOMIC); 113 113 } 114 114 spin_unlock_irqrestore(&lweventlist_lock, flags); 115 115 } ··· 166 166 167 167 netdev_state_change(dev); 168 168 } 169 - dev_put(dev); 169 + dev_put_track(dev, &dev->linkwatch_dev_tracker); 170 170 } 171 171 172 172 static void __linkwatch_run_queue(int urgent_only)