Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

powerpc: 52xx: provide a default in mpc52xx_irqhost_map()

My gcc-4.3.5 fails to compile due to:

|cc1: warnings being treated as errors
|arch/powerpc/platforms/52xx/mpc52xx_pic.c: In function ‘mpc52xx_irqhost_map’:
|arch/powerpc/platforms/52xx/mpc52xx_pic.c:343: error: ‘irqchip’ may be used uninitialized in this function

since commit e34298c ("powerpc: 52xx: nop out unsupported critical
IRQs"). This warning is complete crap since only values 0…3 are possible
which are checked but gcc fails to understand that. I wouldn't care much
but since this is compiled with -Werror I made this patch.
While add it, I replaced the warning from l2irq to l1irq since this is
the number that is evaluated.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Anatolij Gustschin <agust@denx.de>

authored by

Sebastian Siewior and committed by
Anatolij Gustschin
6391f697 d4e4ab86

+2 -1
+2 -1
arch/powerpc/platforms/52xx/mpc52xx_pic.c
··· 373 373 case MPC52xx_IRQ_L1_PERP: irqchip = &mpc52xx_periph_irqchip; break; 374 374 case MPC52xx_IRQ_L1_SDMA: irqchip = &mpc52xx_sdma_irqchip; break; 375 375 case MPC52xx_IRQ_L1_CRIT: 376 + default: 376 377 pr_warn("%s: Critical IRQ #%d is unsupported! Nopping it.\n", 377 - __func__, l2irq); 378 + __func__, l1irq); 378 379 irq_set_chip(virq, &no_irq_chip); 379 380 return 0; 380 381 }