Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

trace: Add __print_ns_to_secs() and __print_ns_without_secs() helpers

To have nanosecond output displayed in a more human readable format, its
nicer to convert it to a seconds format (XXX.YYYYYYYYY). The problem is that
to do so, the numbers must be divided by NSEC_PER_SEC, and moded too. But as
these numbers are 64 bit, this can not be done simply with '/' and '%'
operators, but must use do_div() instead.

Instead of performing the expensive do_div() in the hot path of the
tracepoint, it is more efficient to perform it during the output phase. But
passing in do_div() can confuse the parser, and do_div() doesn't work
exactly like a normal C function. It modifies the number in place, and we
don't want to modify the actual values in the ring buffer.

Two helper functions are now created:

__print_ns_to_secs() and __print_ns_without_secs()

They both take a value of nanoseconds, and the former will return that
number divided by NSEC_PER_SEC, and the latter will mod it with NSEC_PER_SEC
giving a way to print a nice human readable format:

__print_fmt("time=%llu.%09u",
__print_ns_to_secs(REC->nsec_val),
__print_ns_without_secs(REC->nsec_val))

Link: https://lkml.kernel.org/r/e503b903045496c4ccde52843e1e318b422f7a56.1624372313.git.bristot@redhat.com

Cc: Phil Auld <pauld@redhat.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Kate Carcia <kcarcia@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Alexandre Chartre <alexandre.chartre@oracle.com>
Cc: Clark Willaims <williams@redhat.com>
Cc: John Kacur <jkacur@redhat.com>
Cc: Juri Lelli <juri.lelli@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Cc: linux-doc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Daniel Bristot de Oliveira <bristot@redhat.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

+25
+25
include/trace/trace_events.h
··· 358 358 trace_print_hex_dump_seq(p, prefix_str, prefix_type, \ 359 359 rowsize, groupsize, buf, len, ascii) 360 360 361 + #undef __print_ns_to_secs 362 + #define __print_ns_to_secs(value) \ 363 + ({ \ 364 + u64 ____val = (u64)(value); \ 365 + do_div(____val, NSEC_PER_SEC); \ 366 + ____val; \ 367 + }) 368 + 369 + #undef __print_ns_without_secs 370 + #define __print_ns_without_secs(value) \ 371 + ({ \ 372 + u64 ____val = (u64)(value); \ 373 + (u32) do_div(____val, NSEC_PER_SEC); \ 374 + }) 375 + 361 376 #undef DECLARE_EVENT_CLASS 362 377 #define DECLARE_EVENT_CLASS(call, proto, args, tstruct, assign, print) \ 363 378 static notrace enum print_line_t \ ··· 750 735 #undef __get_bitmask 751 736 #undef __print_array 752 737 #undef __print_hex_dump 738 + 739 + /* 740 + * The below is not executed in the kernel. It is only what is 741 + * displayed in the print format for userspace to parse. 742 + */ 743 + #undef __print_ns_to_secs 744 + #define __print_ns_to_secs(val) (val) / 1000000000UL 745 + 746 + #undef __print_ns_without_secs 747 + #define __print_ns_without_secs(val) (val) % 1000000000UL 753 748 754 749 #undef TP_printk 755 750 #define TP_printk(fmt, args...) "\"" fmt "\", " __stringify(args)