Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

firmware: arm_scmi: Convert to SYSTEM_SLEEP_PM_OPS

The old SET_SYSTEM_SLEEP_PM_OPS() macro leads to a warning about an
unused function:

| drivers/firmware/arm_scmi/scmi_power_control.c:363:12: error:
| 'scmi_system_power_resume' defined but not used [-Werror=unused-function]
| static int scmi_system_power_resume(struct device *dev)

The proper way to do this these days is to use SYSTEM_SLEEP_PM_OPS()
and pm_sleep_ptr().

Fixes: 9a0658d3991e ("firmware: arm_scmi: power_control: Ensure SCMI_SYSPOWER_IDLE is set early during resume")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Peng Fan <peng.fan@nxp.com>
Message-Id: <20250709070107.1388512-1-arnd@kernel.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

authored by

Arnd Bergmann and committed by
Sudeep Holla
62d6b81e b5daf93b

+2 -2
+2 -2
drivers/firmware/arm_scmi/scmi_power_control.c
··· 369 369 } 370 370 371 371 static const struct dev_pm_ops scmi_system_power_pmops = { 372 - SET_SYSTEM_SLEEP_PM_OPS(NULL, scmi_system_power_resume) 372 + SYSTEM_SLEEP_PM_OPS(NULL, scmi_system_power_resume) 373 373 }; 374 374 375 375 static const struct scmi_device_id scmi_id_table[] = { ··· 380 380 381 381 static struct scmi_driver scmi_system_power_driver = { 382 382 .driver = { 383 - .pm = &scmi_system_power_pmops, 383 + .pm = pm_sleep_ptr(&scmi_system_power_pmops), 384 384 }, 385 385 .name = "scmi-system-power", 386 386 .probe = scmi_syspower_probe,