sched/preempt: Take away preempt_enable_no_resched() from modules

Discourage drivers/modules to be creative with preemption.

Sadly all is implemented in macros and inline so if they want to do
evil they still can, but at least try and discourage some.

Reviewed-by: Thomas Gleixner <[e-mail]>
Signed-off-by: Peter Zijlstra <[e-mail]>
Cc: Eliezer Tamir <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: Mike Galbraith <[e-mail]>
Cc: [e-mail]
Cc: Rusty Russell <[e-mail]>
Cc: Arjan van de Ven <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: Linus Torvalds <[e-mail]>
Cc: Andrew Morton <[e-mail]>
Link: http://lkml.kernel.org/n/[e-mail]
Signed-off-by: Ingo Molnar <[e-mail]>

include/linux/preempt.h

···
 } while (0)
 
 #else
-#define preempt_enable() preempt_enable_no_resched()
+#define preempt_enable() \
+do { \
+	barrier(); \
+	preempt_count_dec(); \
+} while (0)
 #define preempt_check_resched() do { } while (0)
 #endif
 
···
 		__preempt_schedule_context(); \
 } while (0)
 #else
-#define preempt_enable_notrace() preempt_enable_no_resched_notrace()
+#define preempt_enable_notrace() \
+do { \
+	barrier(); \
+	__preempt_count_dec(); \
+} while (0)
 #endif
 
 #else /* !CONFIG_PREEMPT_COUNT */
···
 #define preempt_enable_notrace()		barrier()
 
 #endif /* CONFIG_PREEMPT_COUNT */
+
+#ifdef MODULE
+/*
+ * Modules have no business playing preemption tricks.
+ */
+#undef sched_preempt_enable_no_resched
+#undef preempt_enable_no_resched
+#undef preempt_enable_no_resched_notrace
+#undef preempt_check_resched
+#endif
 
 #ifdef CONFIG_PREEMPT_NOTIFIERS
 

include/linux/uaccess.h

···
 
 static inline void pagefault_enable(void)
 {
+#ifndef CONFIG_PREEMPT
 	/*
 	 * make sure to issue those last loads/stores before enabling
 	 * the pagefault handler again.
 	 */
 	barrier();
 	preempt_count_dec();
-	preempt_check_resched();
+#else
+	preempt_enable();
+#endif
 }
 
 #ifndef ARCH_HAS_NOCACHE_UACCESS