Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drivers/md: use time_before, time_before_eq, etc

The functions time_before, time_before_eq, time_after, and time_after_eq
are more robust for comparing jiffies against other values.

A simplified version of the semantic patch making this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@ change_compare_np @
expression E;
@@

(
- jiffies <= E
+ time_before_eq(jiffies,E)
|
- jiffies >= E
+ time_after_eq(jiffies,E)
|
- jiffies < E
+ time_before(jiffies,E)
|
- jiffies > E
+ time_after(jiffies,E)
)

@ include depends on change_compare_np @
@@

#include <linux/jiffies.h>

@ no_include depends on !include && change_compare_np @
@@

#include <linux/...>
+ #include <linux/jiffies.h>
// </smpl>

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Julia Lawall and committed by
Linus Torvalds
62b0559a d7a420c9

+2 -1
+2 -1
drivers/md/raid6algos.c
··· 121 121 j0 = jiffies; 122 122 while ( (j1 = jiffies) == j0 ) 123 123 cpu_relax(); 124 - while ( (jiffies-j1) < (1 << RAID6_TIME_JIFFIES_LG2) ) { 124 + while (time_before(jiffies, 125 + j1 + (1<<RAID6_TIME_JIFFIES_LG2))) { 125 126 (*algo)->gen_syndrome(disks, PAGE_SIZE, dptrs); 126 127 perf++; 127 128 }