Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ALSA: compress: fix an integer overflow check

I previously added an integer overflow check here but looking at it now,
it's still buggy.

The bug happens in snd_compr_allocate_buffer(). We multiply
".fragments" and ".fragment_size" and that doesn't overflow but then we
save it in an unsigned int so it truncates the high bits away and we
allocate a smaller than expected size.

Fixes: b35cc8225845 ('ALSA: compress_core: integer overflow in snd_compr_allocate_buffer()')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

authored by

Dan Carpenter and committed by
Takashi Iwai
6217e5ed 892028ac

+1 -1
+1 -1
sound/core/compress_offload.c
··· 491 491 { 492 492 /* first let's check the buffer parameter's */ 493 493 if (params->buffer.fragment_size == 0 || 494 - params->buffer.fragments > SIZE_MAX / params->buffer.fragment_size) 494 + params->buffer.fragments > INT_MAX / params->buffer.fragment_size) 495 495 return -EINVAL; 496 496 497 497 /* now codec parameters */