Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ALSA: au88x0: fix incorrect left shift

vortex_wt_setdsout performs bit-negation on the bit position (wt&0x1f)
rather than on the resulting bitmask. This code is never actually
invoked (vortex_wt_setdsout is always called with en=1), so this does
not currently cause any problem, and this patch is simply cleanup.

Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

authored by

Nickolai Zeldovich and committed by
Takashi Iwai
61ed1dca dc30a436

+1 -1
+1 -1
sound/pci/au88x0/au88x0_synth.c
··· 58 58 if (en) 59 59 temp |= (1 << (wt & 0x1f)); 60 60 else 61 - temp &= (1 << ~(wt & 0x1f)); 61 + temp &= ~(1 << (wt & 0x1f)); 62 62 hwwrite(vortex->mmio, WT_DSREG((wt >= 0x20) ? 1 : 0), temp); 63 63 } 64 64