Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

i2c: designware: determine HS tHIGH and tLOW based on HW parameters

In commit 35eba185fd1a ("i2c: designware: Calculate SCL timing parameter
for High Speed Mode") the SCL high period count and low period count for
high speed mode are calculated based on fixed tHIGH = 160 and tLOW = 120.
However, the set of two fixed values is only applicable to the combination
of hardware parameters IC_CAP_LOADING is 400 and IC_CLK_FREQ_OPTIMIZATION
is true. Outside of this combination, the SCL frequency may not reach
3.4 MHz because the fixed tHIGH and tLOW are not small enough.

If IC_CAP_LOADING is 400, it means the bus capacitance is 400pF;
Otherwise, 100 pF. If IC_CLK_FREQ_OPTIMIZATION is true, it means that the
hardware reduces its internal clock frequency by reducing the internal
latency required to generate the high period and low period of the SCL line.

Section 3.15.4.5 in DesignWare DW_apb_i2b Databook v2.03 says that when
IC_CLK_FREQ_OPTIMIZATION = 0,

MIN_SCL_HIGHtime = 60 ns for 3.4 Mbps, bus loading = 100pF
= 120 ns for 3.4 Mbps, bus loading = 400pF
MIN_SCL_LOWtime = 160 ns for 3.4 Mbps, bus loading = 100pF
= 320 ns for 3.4 Mbps, bus loading = 400pF

and section 3.15.4.6 says that when IC_CLK_FREQ_OPTIMIZATION = 1,

MIN_SCL_HIGHtime = 60 ns for 3.4 Mbps, bus loading = 100pF
= 160 ns for 3.4 Mbps, bus loading = 400pF
MIN_SCL_LOWtime = 120 ns for 3.4 Mbps, bus loading = 100pF
= 320 ns for 3.4 Mbps, bus loading = 400pF

In order to calculate more accurate SCL high period count and low period
count for high speed mode, two hardware parameters IC_CAP_LOADING and
IC_CLK_FREQ_OPTIMIZATION must be considered together. Since there're no
registers controlliing these these two hardware parameters, users can
declare them in the device tree so that the driver can obtain them.

Signed-off-by: Michael Wu <michael.wu@kneron.us>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

authored by

Michael Wu and committed by
Wolfram Sang
61ab42c7 bbc89a6e

+32 -2
+5
drivers/i2c/busses/i2c-designware-common.c
··· 382 382 383 383 i2c_parse_fw_timings(device, t, false); 384 384 385 + if (device_property_read_u32(device, "snps,bus-capacitance-pf", &dev->bus_capacitance_pF)) 386 + dev->bus_capacitance_pF = 100; 387 + 388 + dev->clk_freq_optimized = device_property_read_bool(device, "snps,clk-freq-optimized"); 389 + 385 390 i2c_dw_adjust_bus_speed(dev); 386 391 387 392 if (is_of_node(fwnode))
+6
drivers/i2c/busses/i2c-designware-core.h
··· 242 242 * @set_sda_hold_time: callback to retrieve IP specific SDA hold timing 243 243 * @mode: operation mode - DW_IC_MASTER or DW_IC_SLAVE 244 244 * @rinfo: I²C GPIO recovery information 245 + * @bus_capacitance_pF: bus capacitance in picofarads 246 + * @clk_freq_optimized: if this value is true, it means the hardware reduces 247 + * its internal clock frequency by reducing the internal latency required 248 + * to generate the high period and low period of SCL line. 245 249 * 246 250 * HCNT and LCNT parameters can be used if the platform knows more accurate 247 251 * values than the one computed based only on the input clock frequency. ··· 303 299 int (*set_sda_hold_time)(struct dw_i2c_dev *dev); 304 300 int mode; 305 301 struct i2c_bus_recovery_info rinfo; 302 + u32 bus_capacitance_pF; 303 + bool clk_freq_optimized; 306 304 }; 307 305 308 306 #define ACCESS_INTR_MASK BIT(0)
+21 -2
drivers/i2c/busses/i2c-designware-master.c
··· 151 151 dev->hs_hcnt = 0; 152 152 dev->hs_lcnt = 0; 153 153 } else if (!dev->hs_hcnt || !dev->hs_lcnt) { 154 + u32 t_high, t_low; 155 + 156 + /* 157 + * The legal values stated in the databook for bus 158 + * capacitance are only 100pF and 400pF. 159 + * If dev->bus_capacitance_pF is greater than or equals 160 + * to 400, t_high and t_low are assumed to be 161 + * appropriate values for 400pF, otherwise 100pF. 162 + */ 163 + if (dev->bus_capacitance_pF >= 400) { 164 + /* assume bus capacitance is 400pF */ 165 + t_high = dev->clk_freq_optimized ? 160 : 120; 166 + t_low = 320; 167 + } else { 168 + /* assume bus capacitance is 100pF */ 169 + t_high = 60; 170 + t_low = dev->clk_freq_optimized ? 120 : 160; 171 + } 172 + 154 173 ic_clk = i2c_dw_clk_rate(dev); 155 174 dev->hs_hcnt = 156 175 i2c_dw_scl_hcnt(dev, 157 176 DW_IC_HS_SCL_HCNT, 158 177 ic_clk, 159 - 160, /* tHIGH = 160 ns */ 178 + t_high, 160 179 sda_falling_time, 161 180 0); /* No offset */ 162 181 dev->hs_lcnt = 163 182 i2c_dw_scl_lcnt(dev, 164 183 DW_IC_HS_SCL_LCNT, 165 184 ic_clk, 166 - 320, /* tLOW = 320 ns */ 185 + t_low, 167 186 scl_falling_time, 168 187 0); /* No offset */ 169 188 }