Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/dp_mst: Don't drop NAKs for down responses

It looks like that when we introduced the ability to handle multiple
down requests at once, we accidentally started dropping NAK replies -
causing sideband messages which got NAK'd to seemingly timeout and cause
all sorts of weirdness.

So, fix this by making sure we don't return from
drm_dp_mst_handle_down_rep() early, but instead treat NAKs like any
other message.

Signed-off-by: Lyude Paul <lyude@redhat.com>
Fixes: fbc821c4a506 ("drm/mst: Support simultaneous down replies")
Cc: Wayne Lin <Wayne.Lin@amd.com>
Cc: Wayne Lin <waynelin@amd.com>
Cc: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200403200325.885628-1-lyude@redhat.com
Reviewed-by: Sean Paul <sean@poorly.run>

-1
-1
drivers/gpu/drm/drm_dp_mst_topology.c
··· 3813 3813 txmsg->reply.u.nak.reason, 3814 3814 drm_dp_mst_nak_reason_str(txmsg->reply.u.nak.reason), 3815 3815 txmsg->reply.u.nak.nak_data); 3816 - goto out_clear_reply; 3817 3816 } 3818 3817 3819 3818 memset(msg, 0, sizeof(struct drm_dp_sideband_msg_rx));