Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rename: _request_firmware_load() fw_load_sysfs_fallback()

This reflects much clearer what is being done.
While at it, kdoc'ify it.

Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Luis R. Rodriguez and committed by
Greg Kroah-Hartman
60fa7426 b3cf21fa

+11 -4
+1 -1
Documentation/driver-api/firmware/fallback-mechanisms.rst
··· 112 112 fallback mechanism userspace can be informed of the addition of the device by 113 113 relying on kobject uevents. The addition of the device into the device 114 114 hierarchy means the fallback mechanism for firmware loading has been initiated. 115 - For details of implementation refer to _request_firmware_load(), in particular 115 + For details of implementation refer to fw_load_sysfs_fallback(), in particular 116 116 on the use of dev_set_uevent_suppress() and kobject_uevent(). 117 117 118 118 The kernel's kobject uevent mechanism is implemented in lib/kobject_uevent.c,
+10 -3
drivers/base/firmware_loader/fallback.c
··· 535 535 return fw_sysfs; 536 536 } 537 537 538 - /* load a firmware via user helper */ 539 - static int _request_firmware_load(struct fw_sysfs *fw_sysfs, 538 + /** 539 + * fw_load_sysfs_fallback - load a firmware via the syfs fallback mechanism 540 + * @fw_sysfs: firmware syfs information for the firmware to load 541 + * @opt_flags: flags of options, FW_OPT_* 542 + * @timeout: timeout to wait for the load 543 + * 544 + * In charge of constructing a sysfs fallback interface for firmware loading. 545 + **/ 546 + static int fw_load_sysfs_fallback(struct fw_sysfs *fw_sysfs, 540 547 unsigned int opt_flags, long timeout) 541 548 { 542 549 int retval = 0; ··· 628 621 } 629 622 630 623 fw_sysfs->fw_priv = firmware->priv; 631 - ret = _request_firmware_load(fw_sysfs, opt_flags, timeout); 624 + ret = fw_load_sysfs_fallback(fw_sysfs, opt_flags, timeout); 632 625 633 626 if (!ret) 634 627 ret = assign_fw(firmware, device, opt_flags);