Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

firewire: nosy: char device is not seekable

Amend .open handler accordingly and remove the .llseek handler.
.llseek = NULL means no_llseek (return error) since commit 776c163b1b93.

The only client that uses this interface is nosy-dump in linux/tools/firewire
and it knows not to seek in this char dev.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

+1 -2
+1 -2
drivers/firewire/nosy.c
··· 302 302 303 303 file->private_data = client; 304 304 305 - return 0; 305 + return nonseekable_open(inode, file); 306 306 fail: 307 307 kfree(client); 308 308 lynx_put(lynx); ··· 405 405 .poll = nosy_poll, 406 406 .open = nosy_open, 407 407 .release = nosy_release, 408 - .llseek = noop_llseek, 409 408 }; 410 409 411 410 #define PHY_PACKET_SIZE 12 /* 1 payload, 1 inverse, 1 ack = 3 quadlets */