Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

gpio: max732x: Fix irq-events handler

MAX732X clears all pending interrupts on I2C read (when interrupts
register is being read). Driver doesn't need to send any ACKs when
interrupt was handled. So replace handle_edge_irq() with
handle_simple_irq().

Using handle_edge_irq() (w/o .irq_ack callback set) may lead to NULL
pointer dereference in some cases. E.g. this was observed on
hibernation process:

Unable to handle kernel NULL pointer dereference at virtual address 0
Backtrace:
(handle_edge_irq) from (resend_irqs)
(resend_irqs) from (tasklet_action)
(tasklet_action) from (__do_softirq)
(__do_softirq) from (run_ksoftirqd)
(run_ksoftirqd) from (smpboot_thread_fn)
(smpboot_thread_fn) from (kthread)
(kthread) from (ret_from_fork)

Signed-off-by: Semen Protsenko <semen.protsenko@globallogic.com>
Reviewed-by: Grygorii Strashko <grygorii.strashko@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

authored by

Semen Protsenko and committed by
Linus Walleij
606f13e9 68689dbf

+1 -1
+1 -1
drivers/gpio/gpio-max732x.c
··· 528 528 ret = gpiochip_irqchip_add(&chip->gpio_chip, 529 529 &max732x_irq_chip, 530 530 irq_base, 531 - handle_edge_irq, 531 + handle_simple_irq, 532 532 IRQ_TYPE_NONE); 533 533 if (ret) { 534 534 dev_err(&client->dev,