Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mmc: sdhci-pic32: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Yangtao Li <frank.li@vivo.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20230727070051.17778-9-frank.li@vivo.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

authored by

Yangtao Li and committed by
Ulf Hansson
603b7275 c4a7b258

+2 -4
+2 -4
drivers/mmc/host/sdhci-pic32.c
··· 210 210 return ret; 211 211 } 212 212 213 - static int pic32_sdhci_remove(struct platform_device *pdev) 213 + static void pic32_sdhci_remove(struct platform_device *pdev) 214 214 { 215 215 struct sdhci_host *host = platform_get_drvdata(pdev); 216 216 struct pic32_sdhci_priv *sdhci_pdata = sdhci_priv(host); ··· 221 221 clk_disable_unprepare(sdhci_pdata->base_clk); 222 222 clk_disable_unprepare(sdhci_pdata->sys_clk); 223 223 sdhci_pltfm_free(pdev); 224 - 225 - return 0; 226 224 } 227 225 228 226 static const struct of_device_id pic32_sdhci_id_table[] = { ··· 236 238 .of_match_table = of_match_ptr(pic32_sdhci_id_table), 237 239 }, 238 240 .probe = pic32_sdhci_probe, 239 - .remove = pic32_sdhci_remove, 241 + .remove_new = pic32_sdhci_remove, 240 242 }; 241 243 242 244 module_platform_driver(pic32_sdhci_driver);