Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

riscv module: remove (NOLOAD)

On ELF, (NOLOAD) sets the section type to SHT_NOBITS[1]. It is conceptually
inappropriate for .plt, .got, and .got.plt sections which are always
SHT_PROGBITS.

In GNU ld, if PLT entries are needed, .plt will be SHT_PROGBITS anyway
and (NOLOAD) will be essentially ignored. In ld.lld, since
https://reviews.llvm.org/D118840 ("[ELF] Support (TYPE=<value>) to
customize the output section type"), ld.lld will report a `section type
mismatch` error (later changed to a warning). Just remove (NOLOAD) to
fix the warning.

[1] https://lld.llvm.org/ELF/linker_script.html As of today, "The
section should be marked as not loadable" on
https://sourceware.org/binutils/docs/ld/Output-Section-Type.html is
outdated for ELF.

Link: https://github.com/ClangBuiltLinux/linux/issues/1597
Fixes: ab1ef68e5401 ("RISC-V: Add sections of PLT and GOT for kernel module")
Reported-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Fangrui Song <maskray@google.com>
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>

authored by

Fangrui Song and committed by
Palmer Dabbelt
60210a3d aa5b537b

+3 -3
+3 -3
arch/riscv/include/asm/module.lds.h
··· 2 2 /* Copyright (C) 2017 Andes Technology Corporation */ 3 3 #ifdef CONFIG_MODULE_SECTIONS 4 4 SECTIONS { 5 - .plt (NOLOAD) : { BYTE(0) } 6 - .got (NOLOAD) : { BYTE(0) } 7 - .got.plt (NOLOAD) : { BYTE(0) } 5 + .plt : { BYTE(0) } 6 + .got : { BYTE(0) } 7 + .got.plt : { BYTE(0) } 8 8 } 9 9 #endif