Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ptp: ocp: Add const to bp->attr_group allocation type

In preparation for making the kmalloc family of allocators type aware,
we need to make sure that the returned type from the allocation matches
the type of the variable being assigned. (Before, the allocator would
always return "void *", which can be implicitly cast to any pointer type.)

The assigned type is "const struct attribute_group **", but the returned
type, while technically matching, will be not const qualified. As there is
no general way to safely add const qualifiers, adjust the allocation type
to match the assignment.

Signed-off-by: Kees Cook <kees@kernel.org>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://patch.msgid.link/20250426061858.work.470-kees@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Kees Cook and committed by
Jakub Kicinski
5fe6530c c636eed6

+1 -1
+1 -1
drivers/ptp/ptp_ocp.c
··· 2372 2372 if (attr_tbl[i].cap & bp->fw_cap) 2373 2373 count++; 2374 2374 2375 - bp->attr_group = kcalloc(count + 1, sizeof(struct attribute_group *), 2375 + bp->attr_group = kcalloc(count + 1, sizeof(*bp->attr_group), 2376 2376 GFP_KERNEL); 2377 2377 if (!bp->attr_group) 2378 2378 return -ENOMEM;