Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/amd/display: Remove last parts of timing_trace

Commit c2c2ce1e9623 ("drm/amd/display: Optimize passive update planes.")
removed the last caller of context_timing_trace.
Remove it.

With that gone, no one is now looking at the 'timing_trace' flag, remove
it and all the places that set it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

authored by

Dr. David Alan Gilbert and committed by
Alex Deucher
5fd95dab 8b89acc0

-65
-42
drivers/gpu/drm/amd/display/dc/core/dc_debug.c
··· 46 46 DC_LOG_IF_TRACE(__VA_ARGS__); \ 47 47 } while (0) 48 48 49 - #define TIMING_TRACE(...) do {\ 50 - if (dc->debug.timing_trace) \ 51 - DC_LOG_SYNC(__VA_ARGS__); \ 52 - } while (0) 53 - 54 49 #define CLOCK_TRACE(...) do {\ 55 50 if (dc->debug.clock_trace) \ 56 51 DC_LOG_BANDWIDTH_CALCS(__VA_ARGS__); \ ··· 299 304 300 305 SURFACE_TRACE("post surface process.\n"); 301 306 302 - } 303 - 304 - void context_timing_trace( 305 - struct dc *dc, 306 - struct resource_context *res_ctx) 307 - { 308 - int i; 309 - int h_pos[MAX_PIPES] = {0}, v_pos[MAX_PIPES] = {0}; 310 - struct crtc_position position; 311 - unsigned int underlay_idx = dc->res_pool->underlay_pipe_index; 312 - DC_LOGGER_INIT(dc->ctx->logger); 313 - 314 - 315 - for (i = 0; i < dc->res_pool->pipe_count; i++) { 316 - struct pipe_ctx *pipe_ctx = &res_ctx->pipe_ctx[i]; 317 - /* get_position() returns CRTC vertical/horizontal counter 318 - * hence not applicable for underlay pipe 319 - */ 320 - if (pipe_ctx->stream == NULL || pipe_ctx->pipe_idx == underlay_idx) 321 - continue; 322 - 323 - pipe_ctx->stream_res.tg->funcs->get_position(pipe_ctx->stream_res.tg, &position); 324 - h_pos[i] = position.horizontal_count; 325 - v_pos[i] = position.vertical_count; 326 - } 327 - for (i = 0; i < dc->res_pool->pipe_count; i++) { 328 - struct pipe_ctx *pipe_ctx = &res_ctx->pipe_ctx[i]; 329 - 330 - if (pipe_ctx->stream == NULL || pipe_ctx->pipe_idx == underlay_idx) 331 - continue; 332 - 333 - TIMING_TRACE("OTG_%d H_tot:%d V_tot:%d H_pos:%d V_pos:%d\n", 334 - pipe_ctx->stream_res.tg->inst, 335 - pipe_ctx->stream->timing.h_total, 336 - pipe_ctx->stream->timing.v_total, 337 - h_pos[i], v_pos[i]); 338 - } 339 307 } 340 308 341 309 void context_clock_trace(
-1
drivers/gpu/drm/amd/display/dc/dc.h
··· 868 868 bool sanity_checks; 869 869 bool max_disp_clk; 870 870 bool surface_trace; 871 - bool timing_trace; 872 871 bool clock_trace; 873 872 bool validation_trace; 874 873 bool bandwidth_calcs_trace;
-2
drivers/gpu/drm/amd/display/dc/resource/dcn10/dcn10_resource.c
··· 533 533 .sanity_checks = true, 534 534 .disable_dmcu = false, 535 535 .force_abm_enable = false, 536 - .timing_trace = false, 537 536 .clock_trace = true, 538 537 539 538 /* raven smu dones't allow 0 disp clk, ··· 562 563 static const struct dc_debug_options debug_defaults_diags = { 563 564 .disable_dmcu = false, 564 565 .force_abm_enable = false, 565 - .timing_trace = true, 566 566 .clock_trace = true, 567 567 .disable_stutter = true, 568 568 .disable_pplib_clock_request = true,
-1
drivers/gpu/drm/amd/display/dc/resource/dcn20/dcn20_resource.c
··· 706 706 static const struct dc_debug_options debug_defaults_drv = { 707 707 .disable_dmcu = false, 708 708 .force_abm_enable = false, 709 - .timing_trace = false, 710 709 .clock_trace = true, 711 710 .disable_pplib_clock_request = true, 712 711 .pipe_split_policy = MPC_SPLIT_AVOID_MULT_DISP,
-1
drivers/gpu/drm/amd/display/dc/resource/dcn201/dcn201_resource.c
··· 600 600 static const struct dc_debug_options debug_defaults_drv = { 601 601 .disable_dmcu = true, 602 602 .force_abm_enable = false, 603 - .timing_trace = false, 604 603 .clock_trace = true, 605 604 .disable_pplib_clock_request = true, 606 605 .pipe_split_policy = MPC_SPLIT_DYNAMIC,
-1
drivers/gpu/drm/amd/display/dc/resource/dcn21/dcn21_resource.c
··· 610 610 static const struct dc_debug_options debug_defaults_drv = { 611 611 .disable_dmcu = false, 612 612 .force_abm_enable = false, 613 - .timing_trace = false, 614 613 .clock_trace = true, 615 614 .disable_pplib_clock_request = true, 616 615 .min_disp_clk_khz = 100000,
-1
drivers/gpu/drm/amd/display/dc/resource/dcn30/dcn30_resource.c
··· 711 711 static const struct dc_debug_options debug_defaults_drv = { 712 712 .disable_dmcu = true, //No DMCU on DCN30 713 713 .force_abm_enable = false, 714 - .timing_trace = false, 715 714 .clock_trace = true, 716 715 .disable_pplib_clock_request = true, 717 716 .pipe_split_policy = MPC_SPLIT_DYNAMIC,
-1
drivers/gpu/drm/amd/display/dc/resource/dcn301/dcn301_resource.c
··· 682 682 static const struct dc_debug_options debug_defaults_drv = { 683 683 .disable_dmcu = true, 684 684 .force_abm_enable = false, 685 - .timing_trace = false, 686 685 .clock_trace = true, 687 686 .disable_dpp_power_gate = false, 688 687 .disable_hubp_power_gate = false,
-1
drivers/gpu/drm/amd/display/dc/resource/dcn302/dcn302_resource.c
··· 81 81 static const struct dc_debug_options debug_defaults_drv = { 82 82 .disable_dmcu = true, 83 83 .force_abm_enable = false, 84 - .timing_trace = false, 85 84 .clock_trace = true, 86 85 .disable_pplib_clock_request = true, 87 86 .pipe_split_policy = MPC_SPLIT_DYNAMIC,
-1
drivers/gpu/drm/amd/display/dc/resource/dcn303/dcn303_resource.c
··· 82 82 static const struct dc_debug_options debug_defaults_drv = { 83 83 .disable_dmcu = true, 84 84 .force_abm_enable = false, 85 - .timing_trace = false, 86 85 .clock_trace = true, 87 86 .disable_pplib_clock_request = true, 88 87 .pipe_split_policy = MPC_SPLIT_AVOID,
-1
drivers/gpu/drm/amd/display/dc/resource/dcn31/dcn31_resource.c
··· 858 858 static const struct dc_debug_options debug_defaults_drv = { 859 859 .disable_dmcu = true, 860 860 .force_abm_enable = false, 861 - .timing_trace = false, 862 861 .clock_trace = true, 863 862 .disable_pplib_clock_request = false, 864 863 .pipe_split_policy = MPC_SPLIT_DYNAMIC,
-1
drivers/gpu/drm/amd/display/dc/resource/dcn314/dcn314_resource.c
··· 876 876 .replay_skip_crtc_disabled = true, 877 877 .disable_dmcu = true, 878 878 .force_abm_enable = false, 879 - .timing_trace = false, 880 879 .clock_trace = true, 881 880 .disable_dpp_power_gate = false, 882 881 .disable_hubp_power_gate = false,
-1
drivers/gpu/drm/amd/display/dc/resource/dcn315/dcn315_resource.c
··· 858 858 .disable_z10 = true, /*hw not support it*/ 859 859 .disable_dmcu = true, 860 860 .force_abm_enable = false, 861 - .timing_trace = false, 862 861 .clock_trace = true, 863 862 .disable_pplib_clock_request = false, 864 863 .pipe_split_policy = MPC_SPLIT_DYNAMIC,
-1
drivers/gpu/drm/amd/display/dc/resource/dcn316/dcn316_resource.c
··· 853 853 .disable_z10 = true, /*hw not support it*/ 854 854 .disable_dmcu = true, 855 855 .force_abm_enable = false, 856 - .timing_trace = false, 857 856 .clock_trace = true, 858 857 .disable_pplib_clock_request = false, 859 858 .pipe_split_policy = MPC_SPLIT_DYNAMIC,
-1
drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c
··· 689 689 static const struct dc_debug_options debug_defaults_drv = { 690 690 .disable_dmcu = true, 691 691 .force_abm_enable = false, 692 - .timing_trace = false, 693 692 .clock_trace = true, 694 693 .disable_pplib_clock_request = false, 695 694 .pipe_split_policy = MPC_SPLIT_AVOID, // Due to CRB, no need to MPC split anymore
-1
drivers/gpu/drm/amd/display/dc/resource/dcn321/dcn321_resource.c
··· 686 686 static const struct dc_debug_options debug_defaults_drv = { 687 687 .disable_dmcu = true, 688 688 .force_abm_enable = false, 689 - .timing_trace = false, 690 689 .clock_trace = true, 691 690 .disable_pplib_clock_request = false, 692 691 .pipe_split_policy = MPC_SPLIT_AVOID,
-1
drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c
··· 712 712 static const struct dc_debug_options debug_defaults_drv = { 713 713 .disable_dmcu = true, 714 714 .force_abm_enable = false, 715 - .timing_trace = false, 716 715 .clock_trace = true, 717 716 .disable_pplib_clock_request = false, 718 717 .pipe_split_policy = MPC_SPLIT_AVOID,
-1
drivers/gpu/drm/amd/display/dc/resource/dcn351/dcn351_resource.c
··· 692 692 static const struct dc_debug_options debug_defaults_drv = { 693 693 .disable_dmcu = true, 694 694 .force_abm_enable = false, 695 - .timing_trace = false, 696 695 .clock_trace = true, 697 696 .disable_pplib_clock_request = false, 698 697 .pipe_split_policy = MPC_SPLIT_AVOID,
-1
drivers/gpu/drm/amd/display/dc/resource/dcn401/dcn401_resource.c
··· 685 685 static const struct dc_debug_options debug_defaults_drv = { 686 686 .disable_dmcu = true, 687 687 .force_abm_enable = false, 688 - .timing_trace = false, 689 688 .clock_trace = true, 690 689 .disable_pplib_clock_request = false, 691 690 .pipe_split_policy = MPC_SPLIT_AVOID,
-4
drivers/gpu/drm/amd/display/include/logger_interface.h
··· 52 52 53 53 void post_surface_trace(struct dc *dc); 54 54 55 - void context_timing_trace( 56 - struct dc *dc, 57 - struct resource_context *res_ctx); 58 - 59 55 void context_clock_trace( 60 56 struct dc *dc, 61 57 struct dc_state *context);