Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

powerpc/powermac: Drop unnecessary null test

for_each_node_by_name binds its first argument to a non-null value, and
thus any null test on the value of that argument is superfluous.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
iterator I;
expression x,E;
@@

I(x,...) { <...
(
- (x != NULL) &&
E
...> }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

authored by

Julia Lawall and committed by
Benjamin Herrenschmidt
5fba610e d1efa2a7

+1 -1
+1 -1
arch/powerpc/platforms/powermac/feature.c
··· 2873 2873 2874 2874 /* Switch airport off */ 2875 2875 for_each_node_by_name(np, "radio") { 2876 - if (np && np->parent == macio_chips[0].of_node) { 2876 + if (np->parent == macio_chips[0].of_node) { 2877 2877 macio_chips[0].flags |= MACIO_FLAG_AIRPORT_ON; 2878 2878 core99_airport_enable(np, 0, 0); 2879 2879 }