Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

bluetooth: bluecard_cs: Replace GFP_ATOMIC with GFP_KERNEL in bluecard_hci_set_baud_rate()

bluecard_hci_set_baud_rate() is never called in atomic context.

bluecard_hci_set_baud_rate() is only by bluecard_hci_open(), which is
set to hdev->open, and hdev->open() is never called in atomic context.

bluecard_hci_set_baud_rate() calls bt_skb_alloc() with GFP_ATOMIC,
which is not necessary. GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.
I also manually check the kernel code before reporting it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

authored by

Jia-Ju Bai and committed by
Marcel Holtmann
5f9c6580 6709514f

+1 -1
+1 -1
drivers/bluetooth/bluecard_cs.c
··· 565 565 /* Ericsson baud rate command */ 566 566 unsigned char cmd[] = { HCI_COMMAND_PKT, 0x09, 0xfc, 0x01, 0x03 }; 567 567 568 - skb = bt_skb_alloc(HCI_MAX_FRAME_SIZE, GFP_ATOMIC); 568 + skb = bt_skb_alloc(HCI_MAX_FRAME_SIZE, GFP_KERNEL); 569 569 if (!skb) { 570 570 BT_ERR("Can't allocate mem for new packet"); 571 571 return -1;