rtnetlink: propagate error from dev_change_flags in do_setlink()

Unlike ifconfig, iproute doesn't report an error when setting
an interface up fails:

(example: put wireless network mac80211 interface into repeater mode
with iwconfig but do not set a peer MAC address, it should fail with
-ENOLINK)

without patch:
# ip link set wlan0 up ; echo $?
0
#

with patch:
# ip link set wlan0 up ; echo $?
RTNETLINK answers: Link has been severed
2
#

Propagate the return value from dev_change_flags() to fix this.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Tested-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by Johannes Berg and committed by David S. Miller 5f9021cf 584c650b

+3 -1
+3 -1
net/core/rtnetlink.c
··· 878 878 if (ifm->ifi_change) 879 879 flags = (flags & ifm->ifi_change) | 880 880 (dev->flags & ~ifm->ifi_change); 881 - dev_change_flags(dev, flags); 881 + err = dev_change_flags(dev, flags); 882 + if (err < 0) 883 + goto errout; 882 884 } 883 885 884 886 if (tb[IFLA_TXQLEN])