Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Input: twl4030-pwrbutton - pass the IRQF_ONESHOT flag

Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.

So pass the IRQF_ONESHOT flag in this case.

The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

authored by

Fabio Estevam and committed by
Dmitry Torokhov
5f4eedef 68aeee98

+2 -1
+2 -1
drivers/input/misc/twl4030-pwrbutton.c
··· 71 71 pwr->dev.parent = &pdev->dev; 72 72 73 73 err = devm_request_threaded_irq(&pwr->dev, irq, NULL, powerbutton_irq, 74 - IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING, 74 + IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING | 75 + IRQF_ONESHOT, 75 76 "twl4030_pwrbutton", pwr); 76 77 if (err < 0) { 77 78 dev_err(&pdev->dev, "Can't get IRQ for pwrbutton: %d\n", err);