Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

bonding: 3ad: Print an error for unknown speeds

The bond driver needs to be patched to support new ethtool speeds.
Currently it emits a single warning [1] when it encounters an unknown
speed. As evident by the two previous patches, this is not explicit
enough. Instead, promote it to an error.

[1]
bond10: (slave swp1): unknown ethtool speed (200000) for port 1 (set it to 0)

v2:
* Use pr_err_once() instead of WARN_ONCE()

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Ido Schimmel and committed by
David S. Miller
5edf55ad 138e3b3c

+4 -4
+4 -4
drivers/net/bonding/bond_3ad.c
··· 327 327 default: 328 328 /* unknown speed value from ethtool. shouldn't happen */ 329 329 if (slave->speed != SPEED_UNKNOWN) 330 - pr_warn_once("%s: (slave %s): unknown ethtool speed (%d) for port %d (set it to 0)\n", 331 - slave->bond->dev->name, 332 - slave->dev->name, slave->speed, 333 - port->actor_port_number); 330 + pr_err_once("%s: (slave %s): unknown ethtool speed (%d) for port %d (set it to 0)\n", 331 + slave->bond->dev->name, 332 + slave->dev->name, slave->speed, 333 + port->actor_port_number); 334 334 speed = 0; 335 335 break; 336 336 }