Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
tjh.dev
kernel
os
linux
serial: 8250: longson: Fix NULL vs IS_ERR() bug in probe
The devm_platform_get_and_ioremap_resource() function never returns
NULL, it returns error pointers. Fix the error checking to match.
Fixes: 25e95d763176 ("serial: 8250: Add Loongson uart driver support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aSsIa3KdAlXh5uQC@stanley.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
authored by Dan Carpenter and committed by Greg Kroah-Hartman 5edb7338 24ec03cc
+2
-2
drivers/tty/serial/8250/8250_loongson.c
+2
-2
drivers/tty/serial/8250/8250_loongson.c
···
128
128
port->private_data = priv;
129
129
130
130
port->membase = devm_platform_get_and_ioremap_resource(pdev, 0, &priv->res);
131
-
if (!port->membase)
132
-
return -ENOMEM;
131
+
if (IS_ERR(port->membase))
132
+
return PTR_ERR(port->membase);
133
133
134
134
port->mapbase = priv->res->start;
135
135
port->mapsize = resource_size(priv->res);