Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

target: Fix target_release_cmd_kref shutdown comp leak

This patch fixes an active I/O shutdown bug for fabric
drivers using target_wait_for_sess_cmds(), where se_cmd
descriptor shutdown would result in hung tasks waiting
indefinitely for se_cmd->cmd_wait_comp to complete().

To address this bug, drop the incorrect list_del_init()
usage in target_wait_for_sess_cmds() and always complete()
during se_cmd target_release_cmd_kref() put, in order to
let caller invoke the final fabric release callback
into se_cmd->se_tfo->release_cmd() code.

Reported-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Tested-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

authored by

Himanshu Madhani and committed by
Nicholas Bellinger
5e47f198 4347ab5a

-2
-2
drivers/target/target_core_transport.c
··· 2660 2660 2661 2661 list_for_each_entry_safe(se_cmd, tmp_cmd, 2662 2662 &se_sess->sess_wait_list, se_cmd_list) { 2663 - list_del_init(&se_cmd->se_cmd_list); 2664 - 2665 2663 pr_debug("Waiting for se_cmd: %p t_state: %d, fabric state:" 2666 2664 " %d\n", se_cmd, se_cmd->t_state, 2667 2665 se_cmd->se_tfo->get_cmd_state(se_cmd));